TSDB retention period estimation #270
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* When TSDB is configured with only retention period, we can consider it as "actual" retention period. When it is configured with either retention size or retention period and size, we need to verify that actual retention period by making an API request to `up` query. * Minor refactoring on how we estimate the retention period. * Refactor the frontend loadBalancer initialization and move all middleware related logic into middleware file. * Add unit tests to test all different cases Signed-off-by: Mahendra Paipuri <[email protected]>
mahendrapaipuri
added
bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When TSDB is configured with only retention period, we can consider it as "actual" retention period. When it is configured with either retention size or retention period and size, we need to verify that actual retention period by making an API request to
upquery.Minor refactoring on how we estimate the retention period.
Refactor the frontend loadBalancer initialization and move all middleware related logic into middleware file.
Add unit tests to test all different cases