Merge job stats DB and server commands #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Logical to have both of them in one binary. It reduces maintainence and operation costs * Spawn db update and server in separate go routines Signed-off-by: Mahendra Paipuri <[email protected]>
* Either use sudo or set cap_setuid to make os.setuid() call in subprocess * Do sanity checks before new struct. Exit if sanity checks fail * Mark done after server shutdown Signed-off-by: Mahendra Paipuri <[email protected]>
Signed-off-by: Mahendra Paipuri <[email protected]>
* We refuse to start exporter if slurm collector cannot start * This is the main collector of package and thus we need to fail fast Signed-off-by: Mahendra Paipuri <[email protected]>
Signed-off-by: Mahendra Paipuri <[email protected]>
* Support using sudo or setuid to execute ipmi-dcmi command * Allow to set full ipmi cmd in cli to support different ipmi utils Signed-off-by: Mahendra Paipuri <[email protected]>
Signed-off-by: Mahendra Paipuri <[email protected]>
Signed-off-by: Mahendra Paipuri <[email protected]>
mahendrapaipuri
added
enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
batchjob_stats_serverto do DB updates in a separate go routinesacctandipmicommands