Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Assign accessor names to morph targets #22

Merged
merged 3 commits into from
May 5, 2019
Merged

Assign accessor names to morph targets #22

merged 3 commits into from
May 5, 2019

Conversation

ox
Copy link
Contributor

@ox ox commented Sep 20, 2018

If an accessor has a name, it's morph target should also be named. This is done in the glTF Models repo to name morph targets; see AnimatedMorphCube.

@ox
Copy link
Contributor Author

ox commented Oct 1, 2018

@magicien does this look ok? Anything I should change?

@magicien
Copy link
Owner

magicien commented May 5, 2019

It looks good! Thanks!

@magicien magicien merged commit b05b162 into magicien:master May 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ox @magicien