Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor suggestions + improvements #1

Merged
merged 2 commits into from
Jun 30, 2018

Conversation

goldylucks
Copy link
Contributor

@goldylucks goldylucks commented Jun 27, 2018

Some ideas to consider (or merge :) ) from glancing over the code. Hope this helps, feel free to ask or comment! :)

  • add support for vscode eslint
  • handle multiple classes with classnames
  • validate bitcoin address
  • fix support email text and use constant instead of hardcoded
  • convert routes to constants instead hardcoded
  • use getters to simplify code
  • abstract some reidrect logic to functions
  • move styles to bottom of file (demonstration of putting the "important" stuff above the fold / as higher as possible in the file)
  • simplify rendering (especially in Welcome)
  • export reducers from reducers/reducers.js instead of reducers/index.js - this is a discoverability trick to reduce the amount of index.js files open in the browser, so it's clearer at first glance which file you are working one
  • improve readme

@magician11 magician11 merged commit db88c17 into magician11:master Jun 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants