Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 Improve Session Wallet errors handling #180

Merged
merged 1 commit into from
Oct 16, 2023
Merged

🐛 Improve Session Wallet errors handling #180

merged 1 commit into from
Oct 16, 2023

Conversation

GabrielePicco
Copy link
Collaborator

@GabrielePicco GabrielePicco commented Oct 16, 2023 •
edited
Loading

Improve Session Wallet errors handling

Status Type ⚠️ Core Change Issue
Ready Feature/Bug No -

Problem

As discussed wtih @Woody4618 :

  • Throwing exceptions on bool returning methods

Solution

  • Checked for null accounts rather than throwing exception on bool returning methods

@GabrielePicco GabrielePicco merged commit 8acd918 into main Oct 16, 2023
@GabrielePicco GabrielePicco deleted the feat/improve-session-keys-errors-handling branch October 16, 2023 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@GabrielePicco