Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⚡ Make default commitment configurable from external #37

Merged
merged 6 commits into from
Jul 20, 2023

Conversation

GabrielePicco
Copy link
Contributor

@GabrielePicco GabrielePicco commented Jul 17, 2023

Make default commitment configurable from external

Status Type ⚠️ Core Change Issue
Ready/ Feature No -

Problem

Default commitment not configurable after RPC initialization

Solution

Make default commitment configurable from external

Issues

Closes #34

@coveralls
Copy link

coveralls commented Jul 18, 2023

Pull Request Test Coverage Report for Build 5597319874

  • 0 of 2 (0.0%) changed or added relevant lines in 1 file are covered.
  • 14 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.002%) to 73.135%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/Solana.Unity.Rpc/SolanaRpcClient.cs 0 2 0.0%
Files with Coverage Reduction New Missed Lines %
src/Solana.Unity.Rpc/SolanaRpcClient.cs 14 91.53%
Totals Coverage Status
Change from base Build 5574909605: -0.002%
Covered Lines: 4755
Relevant Lines: 6209

💛 - Coveralls

@GabrielePicco GabrielePicco merged commit fe708bc into master Jul 20, 2023
@GabrielePicco GabrielePicco deleted the enhance/default-commitment-configurable branch July 20, 2023 07:03
xiaolou86 pushed a commit to xiaolou86/Solana.Unity-Core that referenced this pull request Oct 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add configurable default commitment for RPC calls
2 participants