history: Work around glibc's fsetpos bug #117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The fsetpos function in glibc seems to be buggy. It sometimes sets the FILE's error indicator without actually setting errno. This causes the shell to fail to update the history file. To work around this issue, the shell now checks the error indicator after calling fsetpos and re-reads the history file from the beginning if it is set. The check script for working I/O functions in configure is updated in an attempt to reproduce the issue, but currently it does not catch the bug (at least on my environment with glibc 2.40 on Fedora 41).
magicant
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The fsetpos function in glibc seems to be buggy. It sometimes sets the FILE's error indicator without actually setting errno. This causes the shell to fail to update the history file. To work around this issue, the shell now checks the error indicator after calling fsetpos and re-reads the history file from the beginning if it is set.
The check script for working I/O functions in configure is updated in an attempt to reproduce the issue, but currently it does not catch the bug (at least on my environment with glibc 2.40 on Fedora 41).