Fixed the UI issue: Height issue of editor and The Spacing issue betw…

…een logo and description (datahub-project#4300)
maggiehays · Aug 1, 2022 · 7353557 · 7353557
1 parent 1277a8c
commit 7353557
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 3 deletions.
diff --git a/datahub-web-react/src/app/entity/shared/containers/profile/EntityProfile.tsx b/datahub-web-react/src/app/entity/shared/containers/profile/EntityProfile.tsx
@@ -56,6 +56,7 @@ const ContentContainer = styled.div`
 const HeaderAndTabs = styled.div`
     flex-basis: 70%;
     min-width: 640px;
+    height: 100%;
 `;
 const HeaderAndTabsFlex = styled.div`
     display: flex;
@@ -244,7 +245,7 @@ export const EntityProfile = <T, U>({
                             defaultSize={window.innerWidth - 400}
                             resizerStyle={resizerStyles}
                             style={{
-                                height: 'auto',
+                                height: '100%',
                                 overflow: 'auto',
                             }}
                         >

diff --git a/datahub-web-react/src/app/preview/DefaultPreviewCard.tsx b/datahub-web-react/src/app/preview/DefaultPreviewCard.tsx
@@ -21,6 +21,10 @@ import NoMarkdownViewer from '../entity/shared/components/styled/StripMarkdownTe
 import { getNumberWithOrdinal } from '../entity/shared/utils';
 import { useEntityData } from '../entity/shared/EntityContext';
 
+const LogoContainer = styled.div`
+    padding-right: 8px;
+`;
+
 const PreviewContainer = styled.div`
     display: flex;
     width: 100%;
@@ -201,8 +205,9 @@ export default function DefaultPreviewCard({
                 <TitleContainer>
                     <Link to={url}>
                         <PlatformInfo>
-                            {(logoUrl && <PreviewImage preview={false} src={logoUrl} alt={platform || ''} />) ||
-                                logoComponent}
+                            {(logoUrl && <PreviewImage preview={false} src={logoUrl} alt={platform || ''} />) || (
+                                <LogoContainer>{logoComponent}</LogoContainer>
+                            )}
                             {platform && <PlatformText>{platform}</PlatformText>}
                             {(logoUrl || logoComponent || platform) && <PlatformDivider />}
                             {typeIcon && <TypeIcon>{typeIcon}</TypeIcon>}