Code

Refactor contact module#8420

Code

Merged

mmansoor-magento merged 19 commits intomagento:developmagento/magento2:developfrom schmengler:contact-refactorCopy head branch name to clipboardFeb 25, 2017

+667-290

Commits

Commits on Feb 4, 2017

• Remove Zend_Validate calls

  schmengler

  committed
  47a4681

  Copy full SHA for 47a4681

• Replace Zend_Validate_EmailAddress with 100% correct email validation

  Show description for e1d47cc
  schmengler

  committed
  e1d47cc

  Copy full SHA for e1d47cc

• Extract sendEmail method in contact form controller

  schmengler

  committed
  962c06d

  Copy full SHA for 962c06d

• Extract validatedParams method in contact form controller, use redirect result factory

  schmengler

  committed
  fb902c6

  Copy full SHA for fb902c6

• Show meaningful error message if contact form validation fails

  schmengler

  committed
  352dcef

  Copy full SHA for 352dcef

• Make validation and sending methods in contacts form controller protected

  Show description for c8fbb70
  schmengler

  committed
  c8fbb70

  Copy full SHA for c8fbb70

• Add docblock comments

  schmengler

  committed
  36261ea

  Copy full SHA for 36261ea

• Update unit test

  schmengler

  committed
  ec3fad1

  Copy full SHA for ec3fad1

• Fix code style violations

  schmengler

  committed
  0c78857

  Copy full SHA for 0c78857

Commits on Feb 16, 2017

• Revert "Make validation and sending methods in contacts form controller protected"

  Show description for b4f68b0
  schmengler

  committed
  b4f68b0

  Copy full SHA for b4f68b0

• Remove unnecessary dependency

  Show description for 5854390
  schmengler

  committed
  5854390

  Copy full SHA for 5854390

• Moved down unnecessary dependencies from abstract base controller in contacts module

  Show description for 854f16d
  schmengler

  committed
  854f16d

  Copy full SHA for 854f16d

• Move configuration access to config model / API interface

  Show description for 22004d7
  schmengler

  committed
  22004d7

  Copy full SHA for 22004d7

• Merge remote-tracking branch 'origin/develop' into contact-refactor

  Show description for cdf8725
  schmengler

  committed
  cdf8725

  Copy full SHA for cdf8725

• Extract mail sending from contacts controller, introduce mail service contract

  schmengler

  committed
  28d939f

  Copy full SHA for 28d939f

• Add docblock comments and empty lines

  schmengler

  committed
  7a01613

  Copy full SHA for 7a01613

• Add missing preference

  schmengler

  committed
  0261088

  Copy full SHA for 0261088

Commits on Feb 19, 2017

• Move contact form interfaces from Api to Model namespace

  schmengler

  committed
  a5c69d0

  Copy full SHA for a5c69d0

• Make method signature of Mail::send() more precise

  schmengler

  committed
  f5ac9f7

  Copy full SHA for f5ac9f7