Fix swatch-renderer.js 843:866 #8105
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hello, There is an error in console when product has more than one swatch: Uncaught TypeError: Cannot read property 'oldPrice' of undefined - swatch-renderer.js:843 Step to reproduce: 1) Install Sample Data 2) Go to PDP where product has more than one swatch, for example ../augusta-pullover-jacket.html 3) Select some Color and look to the console - there You will be able to see the error. This is because 'result' is null before all of the swatches are selected. Some fixes have been added. Please, test. Thanks.
zetlen
suggested changes
Mar 1, 2017
| } else { | ||
| $(this.options.slyOldPriceSelector).hide(); | ||
| } | ||
| if (typeof(result) != "undefined") { |
There was a problem hiding this comment.
Though the typeof operator can be used with parentheses, it is not recommended, because it can confuse linters and reviewers. This should be typeof result.
There was a problem hiding this comment.
Thanks, it make sence.
| $(this.options.tierPriceBlockSelector).html(tierPriceHtml).show(); | ||
| } | ||
| } else { | ||
| $(this.options.tierPriceBlockSelector).hide(); |
There was a problem hiding this comment.
If result.tierPrices.length != 0 and !this.options.tierPriceTemplate, then this.options.tierPriceBlockSelector will be neither shown nor hidden. Is this the desired behavior?
There was a problem hiding this comment.
Thanks, I'll pull new code, investigte it and fix if needed.
|
@aholovan thanks for contribution! Can you please update PR per the comments? |
|
I've created new pull request #8923. |
magento-devops-reposync-svc
pushed a commit
that referenced
this pull request
Mar 14, 2023
…sues_29Jan22 Hammer release regression issues 29 jan22
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
There is an error in console when product has more than one kind of swatches:
Uncaught TypeError: Cannot read property 'oldPrice' of undefined - swatch-renderer.js:843
Step to reproduce:
Some fixes have been added. Please, test.
Thanks.