-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set static html fragments as cacheable #8000
Conversation
I believe one failing integration test has nothing to do this with PR, and it related to something else. |
What do you think, should we also send Cache-Control public for html files?
|
We are accepting current pull request, but in future this behavior would be modified in Magento as Varnish should not be used for caching and serving static content as html, images, css and other media. |
@maghamed Does not this relate to where Varnish layer is? In case of Varnish residing in the same server/DC not caching static content there can make sense, but what in case where Varnish layer in in the edge (eg. Fastly service) and used as CDN? |
@paveq Thank you for your contribution! PR number == 8000 :) Good catch! |
[Bluetooth] Community Pull Requests delivery - 2.4-develop
Fixes issue where some of static content (knockout templates) are retrieved again for every request from the server, depending on apache configuration. With this modification we no longer depend on specifics of environment apache configuration.