-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update AccountLock.php #6952
Merged
Merged
Update AccountLock.php #6952
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix for "Notice: Undefined index: lock_expires in vendor/magento/module-customer/Ui/Component/Listing/Column/AccountLock.php on line 44"
ihor-sviziev
approved these changes
Oct 11, 2016
slavvka
added
Issue: Ready for Work
Gate 4. Acknowledged. Issue is added to backlog and ready for development
Progress: accept
labels
Oct 19, 2016
@klict, please cover your change with unit test. |
i can't perform unit test right now. if you want to add the small fix you can do it but i really don't care if you don't add it. |
mmansoor-magento
pushed a commit
that referenced
this pull request
Dec 7, 2016
mmansoor-magento
pushed a commit
that referenced
this pull request
Dec 7, 2016
[South] Bugs: - MAGETWO-56072 [Performance] Image resize mechanism does not generate images of all necessary sizes - MAGETWO-59904 [PR][Github] Update AccountLock.php #6952 - MAGETWO-53550 [Github][PR] Fix newsletter queue subscribers adding performance #4088 - MAGETWO-60047 [Porting] Error on adding address during checkout if add custom customer address attribute of file type - 2.2 - MAGETWO-56396 "Go Today" button in filter type date doesn`t apply value - MAGETWO-59365 Countries list is not loaded if change customer website after country was selected - MAGETWO-59924 File attribute doesn't have placeholder in admin
Still not included in 2.1.10 |
@Ctucker9233 this fix included to release 2.2.0. You could prepare backport PR to |
ihor-sviziev
added
Fixed in 2.2.x
The issue has been fixed in 2.2 release line
Release Line: 2.2
and removed
Progress: needs update
labels
Nov 11, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Component: Customer
Fixed in 2.2.x
The issue has been fixed in 2.2 release line
Issue: Ready for Work
Gate 4. Acknowledged. Issue is added to backlog and ready for development
Progress: accept
Release Line: 2.2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix for "Notice: Undefined index: lock_expires in vendor/magento/module-customer/Ui/Component/Listing/Column/AccountLock.php on line 44"