Admin product edit block getHeader is not used #6322
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Just removing this method since it's not used, so people don't get mislead into creating a plugin for that and wondering why it does not work. `\Magento\Theme\Block\Html\Title::getPageTitle()` returns the title instead.
|
@kassner removing the public method is a backward incompatible change. Unfortunately, we cannot accept this PR as far as it can break existing extensions |
|
@vrann can we at least put a |
|
@kassner let's do that |
|
@vrann Done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just removing this method since it's not used, so people don't get mislead into creating a plugin for that and wondering why it does not work.
\Magento\Theme\Block\Html\Title::getPageTitle()returns the title instead.