Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change 'select' to 'query' in props #5043

Merged
merged 3 commits into from
Apr 13, 2017
Merged

Change 'select' to 'query' in props #5043

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7c534a2
Change 'select' to 'query' in props
flancer64 Jun 15, 2016
a4d6994
Fix Travis CI error
flancer64 Jun 15, 2016
fca2421
QueryInterface & old $select
flancer64 Jun 17, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions lib/internal/Magento/Framework/Data/AbstractSearchResult.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,8 +58,14 @@ abstract class AbstractSearchResult extends AbstractDataObject implements Search
*/
protected $entityFactory;

/**
* @var \Magento\Framework\DB\QueryInterface
*/
protected $query;
Copy link

@vkublytskyi vkublytskyi Jun 17, 2016 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can't remove protected properties now due to backward compatibility policy. Even if these properties are not used. Such properties should be marked with @deprecated PHPDoc tag.


/**
* @var \Magento\Framework\DB\Select
* @deprecated
*/
protected $select;

Expand Down