Make NL zipcode pattern less strict #4874
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The NL zipcode is too strict. Magento 2 advises `1234 AB`, while it's very common to enter it like `1234AB`. That's why I made the space character optional.
|
@MomotenkoNatalia can this pr be rebuild? At the time I created this pr, the |
|
Is this fix applied in version 2.1? |
|
@HRR1337 No, it's waiting for approval. |
vkorotun
added
Application Framework
improvement
Issue: Ready for Work
vkorotun
added
bugfix
and removed
Issue: Ready for Work
|
Any progress on this yet? |
|
@tdgroot thank you for the contribution! |
magento-engcom-team
pushed a commit
that referenced
this pull request
Oct 15, 2019
MAGETWO-99161: Frontend cookies are not set with secure flag on https
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The NL zipcode is too strict.
Magento 2 advises
1234 AB, while it's very common to enter it like1234AB.That's why I made the space character optional.