Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correction: variable naming for user roles & role id #4491

Merged
merged 1 commit into from
Aug 21, 2016
Merged

Correction: variable naming for user roles & role id #4491

merged 1 commit into from
Aug 21, 2016

Conversation

MagePsycho
Copy link
Contributor

Just to avoid the short hands from variable names. Variable names should be meaningful.

@vkorotun
Copy link
Contributor

Yeah, you are right, and thank you for contributing to Magento.
We'll take this in the pool request processing pipe soon.

@vkorotun vkorotun added the CS label May 26, 2016
@vkorotun vkorotun added Admin Panel Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Progress: accept improvement and removed Application Framework labels Aug 4, 2016
@paliarush paliarush self-assigned this Aug 4, 2016
@vkorotun vkorotun removed the Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development label Aug 5, 2016
@sshrewz
Copy link

sshrewz commented Aug 9, 2016

Internal ticket - MAGETWO-56733

@sshrewz sshrewz added the linked label Aug 9, 2016
@ghost
Copy link

ghost commented Aug 10, 2016

Removed "accept" label by mistake. This ticket was accepted earlier by the architect.

@mmansoor-magento mmansoor-magento merged commit e84b5a5 into magento:develop Aug 21, 2016
mmansoor-magento pushed a commit that referenced this pull request Aug 21, 2016
MAGETWO-56733: [GitHub][PR]Correction: variable naming for user roles…
ffe77cd 
… & role id #4491

- Merge branch 'feature-variable-fix' of https://github.com/MagePsycho/magento2 into MagePsycho-feature-variable-fix
@vkorotun vkorotun added Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development and removed linked labels Aug 22, 2016
magento-engcom-team pushed a commit that referenced this pull request Jul 23, 2019
@danielrenaud
Merge pull request #4491 from magento-techdivision/varnish6_update
777b0b0 
[TechDivision] Varnish 6 update
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@paliarush paliarush

Labels
improvement Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Progress: accept
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@MagePsycho @vkorotun @sshrewz @mmansoor-magento @paliarush @NadiyaS