Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unused variables in unit test #3155

Merged
merged 1 commit into from
Feb 15, 2017
Merged

Remove unused variables in unit test #3155

merged 1 commit into from
Feb 15, 2017

Conversation

fooman
Copy link
Contributor

@fooman fooman commented Jan 27, 2016 •
edited by okorshenko
Loading

No description provided.

@Vinai Vinai added the PS label Jan 27, 2016
@Vinai
Copy link
Contributor

Vinai commented Jan 27, 2016

It seems the broken integration test has nothing to do with the changes in the PR.

@fooman
Copy link
Contributor Author

fooman commented Jan 27, 2016

Thanks @Vinai - the memory test has been fluctuating for me locally on other occasions as well (and it seems for Magento as well

magento2/dev/tests/integration/testsuite/Magento/MemoryUsageTest.php

Line 69 in 6fb4e9d

protected function _getAllowedMemoryUsage()
). And yes I fail to see how deleting a variable in a test (which wouldn't be initialised as part of the memory test I think) could make it worse.

@vancoz vancoz self-assigned this Jan 29, 2016
@sshrewz sshrewz added the Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development label Feb 26, 2016
@vancoz
Copy link

vancoz commented Apr 28, 2016

Internal ticket MAGETWO-52389

@vkorotun vkorotun added Component: Tax improvement and removed PS Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development labels Aug 3, 2016
@sshrewz sshrewz added the linked label Aug 11, 2016
@vkorotun vkorotun added Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development and removed linked labels Aug 22, 2016
@wert2all wert2all self-requested a review January 30, 2017 10:52
@wert2all wert2all self-assigned this Jan 30, 2017
@okorshenko okorshenko added this to the February 2017 milestone Feb 11, 2017
@mmansoor-magento mmansoor-magento merged commit 32cffa5 into magento:develop Feb 15, 2017
@okorshenko
Copy link
Contributor

@fooman thank you for your contribution

@vrann vrann added the simple label Mar 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wert2all wert2all Awaiting requested review from wert2all

Assignees

@wert2all wert2all

Labels
Component: Tax improvement Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Progress: accept
Projects
None yet
Milestone
February 2017
Development

Successfully merging this pull request may close these issues.
9 participants
@fooman @Vinai @vancoz @okorshenko @vrann @mmansoor-magento @wert2all @vkorotun @sshrewz