-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add missing "VAT Number" field to customer registration page #31321
Add missing "VAT Number" field to customer registration page #31321
Conversation
It was copied from nearby address/edit.phtml template
Hi @vovayatsyuk. Thank you for your contribution
❗ Automated tests can be triggered manually with an appropriate comment:
You can find more information about the builds here ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review. For more details, please, review the Magento Contributor Guide documentation. 🕙 You can find the schedule on the Magento Community Calendar page. 📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket. 🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel ✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel |
@magento create issue |
@magento run all tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @vovayatsyuk, thanks for contributing! We must cover such changes with automated tests, I believe MFTF would suit best in this case. Are you able to add MFTF cover to this PR?
Thanks.
Hi @vovayatsyuk, I will help with the test. |
Thank you! |
@magento run all tests |
@magento run Functional Tests B2B, Functional Tests CE, Functional Tests EE |
Hi @gabrieldagama, thank you for the review.
|
✔️ QA Passed Manual testing scenarios
Before: ✖️ Address fields are shown but "VAT Number" field is missing. After: ✔️ "VAT Number" is shown Also, was checked in different places, with a disabled "Show VAT Number on Storefront" option and everything works as expected. |
…hipping-registration-page' into fix-missing-vatid-at-multishipping-registration-page
@magento run all tests |
Hi @vovayatsyuk, thank you for your contribution! |
Description
This commits makes "VAT Number" field visible when
customer/create_account/vat_frontend_visibility
is enabled.The code was copied from nearby address/edit.phtml template.
Manual testing scenarios
Show VAT Number on Storefront
option at Stores > Configuration > Customers > Customer Configuration > Create New Account Options > Show VAT Number on StorefrontContribution checklist (*)
Resolved issues:
Related Pull Requests
https://github.com/magento/partners-magento2ee/pull/443