Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing "VAT Number" field to customer registration page #31321

Conversation

vovayatsyuk
Copy link
Member

@vovayatsyuk vovayatsyuk commented Dec 17, 2020

Description

This commits makes "VAT Number" field visible when customer/create_account/vat_frontend_visibility is enabled.
The code was copied from nearby address/edit.phtml template.

Manual testing scenarios

  1. Enable Show VAT Number on Storefront option at Stores > Configuration > Customers > Customer Configuration > Create New Account Options > Show VAT Number on Storefront
  2. Navigate to frontend and add some product to the cart.
  3. Proceed to Multishipping checkout and select "Create Account" option
  4. Address fields are shown but "VAT Number" field is missing.

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

Resolved issues:

  1. resolves [Issue] Add missing "VAT Number" field to customer registration page #31326: Add missing "VAT Number" field to customer registration page

Related Pull Requests

https://github.com/magento/partners-magento2ee/pull/443

It was copied from nearby address/edit.phtml template
@m2-assistant
Copy link

m2-assistant bot commented Dec 17, 2020

Hi @vovayatsyuk. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE,
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

@gabrieldagama
Copy link
Contributor

@magento create issue

@gabrieldagama gabrieldagama added Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Severity: S2 Major restrictions or short-term circumventions are required until a fix is available. and removed Progress: pending review labels Dec 17, 2020
@gabrieldagama
Copy link
Contributor

@magento run all tests

Copy link
Contributor

@gabrieldagama gabrieldagama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @vovayatsyuk, thanks for contributing! We must cover such changes with automated tests, I believe MFTF would suit best in this case. Are you able to add MFTF cover to this PR?

Thanks.

@engcom-Hotel
Copy link
Contributor

Hi @vovayatsyuk, I will help with the test.

@vovayatsyuk
Copy link
Member Author

Thank you!

@engcom-Hotel
Copy link
Contributor

@magento run all tests

@engcom-Hotel
Copy link
Contributor

@magento run Functional Tests B2B, Functional Tests CE, Functional Tests EE

@magento-engcom-team
Copy link
Contributor

Hi @gabrieldagama, thank you for the review.
ENGCOM-8617 has been created to process this Pull Request
✳️ @gabrieldagama, could you please add one of the following labels to the Pull Request?

Label Description
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests
Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests
Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests

@engcom-Alfa
Copy link
Contributor

✔️ QA Passed

Manual testing scenarios

  1. Enable Show VAT Number on Storefront option at Stores > Configuration > Customers > Customer Configuration > Create New Account Options > Show VAT Number on Storefront
  2. Navigate to frontend and add some product to the cart.
  3. Proceed to Multishipping checkout and select "Create Account" option

Before: ✖️ Address fields are shown but "VAT Number" field is missing.

Screenshot from 2021-01-13 11-05-37

After: ✔️ "VAT Number" is shown

2021-01-13_11-18

Also, was checked in different places, with a disabled "Show VAT Number on Storefront" option and everything works as expected.

@engcom-Hotel
Copy link
Contributor

@magento run all tests

@m2-assistant
Copy link

m2-assistant bot commented Jan 24, 2021

Hi @vovayatsyuk, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Frontend Component: Customer Component: Multishipping Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: accept QA: Added to Regression Scope Scenario was analysed and added to Regression Testing Scope Release Line: 2.4 Severity: S2 Major restrictions or short-term circumventions are required until a fix is available.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Issue] Add missing "VAT Number" field to customer registration page
5 participants