Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MFTF] Refactoring of AdminMassProductPriceUpdateTest #31057

Merged
merged 13 commits into from
Jan 6, 2021
Merged

[MFTF] Refactoring of AdminMassProductPriceUpdateTest #31057

merged 13 commits into from
Jan 6, 2021

Conversation

AnnaAPak
Copy link
Contributor

@AnnaAPak AnnaAPak commented Nov 25, 2020 •
edited by m2-assistant bot
Loading

Description (*)

The test is refactored according to the best practices followed by MFTF.

Manual testing scenarios (*)

  1. Create 2 simple products
  2. Go to Admin->Catalog->Products
  3. Update price of the products via mass update
  4. Check if price is updated on the Product Edit page (for both products)

Resolved issues:

  1. resolves [Issue] [MFTF] Refactoring of AdminMassProductPriceUpdateTest #31073: [MFTF] Refactoring of AdminMassProductPriceUpdateTest

@m2-assistant
Copy link

m2-assistant bot commented Nov 25, 2020

Hi @AnnaAPak. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE,
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

@magento-engcom-team magento-engcom-team added Component: Catalog Release Line: 2.4 Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner labels Nov 25, 2020
@AnnaAPak
delete unneeded file
bdb653d 
 Please enter the commit message for your changes. Lines starting
@AnnaAPak AnnaAPak changed the title Refactoring of AdminMassProductPriceUpdateTest WIP [MFTF] Refactoring of AdminMassProductPriceUpdateTest Nov 25, 2020
@AnnaAPak AnnaAPak changed the title WIP [MFTF] Refactoring of AdminMassProductPriceUpdateTest [MFTF] Refactoring of AdminMassProductPriceUpdateTest Nov 25, 2020
@AnnaAPak
extended decription fo Action Group
dd4334d 
 Please enter the commit message for your changes. Lines starting
@AnnaAPak
Copy link
Contributor Author

@magento run Functional Tests CE, Functional Tests EE, Functional Tests B2B

@rogyar rogyar self-assigned this Nov 26, 2020
@gabrieldagama gabrieldagama added Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Severity: S2 Major restrictions or short-term circumventions are required until a fix is available. labels Nov 26, 2020
@gabrieldagama
Copy link
Contributor

@magento create issue

@m2-assistant m2-assistant bot mentioned this pull request Nov 26, 2020
Closed
rogyar
rogyar requested changes Nov 29, 2020
View reviewed changes
app/code/Magento/Catalog/Test/Mftf/Test/AdminMassProductPriceUpdateTest.xml Outdated
@@ -25,56 +25,64 @@
</before>
<after>
<deleteData createDataKey="simpleProduct1" stepKey="deleteSimpleProduct1"/>
<deleteData createDataKey="simpleProduct2" stepKey="deleteSimpleProduct2"/>
<deleteData createDataKey="simpleProduct2" stepKey="deleteSimpleProduct2"/>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, remove the trailing space at the end.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed, thank you.

app/code/Magento/Catalog/Test/Mftf/ActionGroup/AdminCheckProductOnProductGridActionGroup.xml Outdated
<checkOption selector="{{AdminProductGridSection.productRowCheckboxBySku(product.sku)}}" stepKey="selectProduct"/>

</actionGroup>
</actionGroups>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @AnnaAPak. Could I ask you to add an empty line at the end of the file, please?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added, thanks.

@rogyar rogyar added the Auto-Tests: Covered All changes in Pull Request is covered by auto-tests label Dec 6, 2020
@rogyar
Copy link
Contributor

rogyar commented Dec 6, 2020

@magento run Functional Tests CE, Functional Tests EE, Functional Tests B2B

@engcom-Charlie
Merge branch '2.4-develop' into ref-AdminMassProductPriceUpdateTest
b3efee9 
# Conflicts:
#	app/code/Magento/Catalog/Test/Mftf/ActionGroup/AdminCheckProductOnProductGridActionGroup.xml
@engcom-Charlie
Copy link
Contributor

@magento run all tests

@magento-engcom-team
Copy link
Contributor

Hi @rogyar, thank you for the review.
ENGCOM-8587 has been created to process this Pull Request

@engcom-Alfa engcom-Alfa self-assigned this Dec 28, 2020
@engcom-Alfa
Copy link
Contributor

QA not applicable

magento-engcom-team pushed a commit that referenced this pull request Jan 6, 2021
@gabrieldagama
ENGCOM-8587: [MFTF] Refactoring of AdminMassProductPriceUpdateTest #3…
c1ab666 
…1057
@magento-engcom-team magento-engcom-team merged commit fae1c14 into magento:2.4-develop Jan 6, 2021
@m2-assistant
Copy link

m2-assistant bot commented Jan 6, 2021

Hi @AnnaAPak, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rogyar rogyar rogyar approved these changes

Assignees

@rogyar rogyar

@engcom-Alfa engcom-Alfa

@engcom-Charlie engcom-Charlie

Labels
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests Component: Catalog Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: accept Release Line: 2.4 Severity: S2 Major restrictions or short-term circumventions are required until a fix is available.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Issue] [MFTF] Refactoring of AdminMassProductPriceUpdateTest
6 participants
@AnnaAPak @gabrieldagama @engcom-Charlie @rogyar @magento-engcom-team @engcom-Alfa