Fix #28011 - remove page number from query on layered navigation swatch filter

[Bartlomiejsz]

Description (*)

This change makes swatch layered navigation filter consistent with standard filters, by removing p query parameter from filter url in same way as in https://github.com/magento/magento2/blob/2.4-develop/app/code/Magento/Catalog/Model/Layer/Filter/Item.php
Fixes #28011

Related Pull Requests

Fixed Issues (if relevant)

1. ElasticSearch When applying the extra filter to the product listing, Magento keeps the same page number #28011: ElasticSearch When applying the extra filter to the product listing, Magento keeps the same page number

Manual testing scenarios (*)

1. Have at least one swatch filter on layered navigation and multiple pages of products
2. Go to last page on PLP
3. Use swatch attribute as filter
4. p parameter should be removed from url and user should see first page, same as when non-swatch attribute is used as filter

Questions or comments

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• All automated tests passed successfully (all builds are green)

[m2-assistant]

Hi @Bartlomiejsz. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento give me test instance - deploy test instance based on PR changes
• @magento give me 2.4-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

[lbajsarowicz]

As it's an adaptation of another bugfix (made to another part of the system), I am approving that.
Thanks for cleaning up the code style there.

[magento-engcom-team]

Hi @lbajsarowicz, thank you for the review.
ENGCOM-7493 has been created to process this Pull Request
✳️ @lbajsarowicz, could you please add one of the following labels to the Pull Request?

Label	Description
Auto-Tests: Covered	All changes in Pull Request is covered by auto-tests
Auto-Tests: Not Covered	Changes in Pull Request requires coverage by auto-tests
Auto-Tests: Not Required	Changes in Pull Request does not require coverage by auto-tests

[ihor-sviziev]

Hi @Bartlomiejsz,
Could you fix the failing static tests and cover your change with any type of test? I see you already adjusted unit tests, but I can't see any change related to the bug itself.

Pull Request state was updated. Re-review required.

[Bartlomiejsz]

Hi @ihor-sviziev, indeed I only did minor adjustments to unit test because otherwise it would fail due to new dependency injected. I didn't add new unit test since this whole test file will either need to be reworked or removed for phpunit 9 because it tests mock and not real class which I think won't work anymore.
I will try to cover this change with functional test

[engcom-Alfa]

✔️ QA Passed

[engcom-Charlie]

Failed functional test not related to changes from this PR.

[m2-assistant]

Hi @Bartlomiejsz, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.