Fix Arabic and Hebrew in invoices

[ihor-sviziev]

Description (*)

I found fix that was reverted in 1c0549e due to backward compatibility issues (from @lenaorobei). I just re-applied these changes again, extracted whole logic with working with RTL texts to the separate model, covered it with unit tests and used it during invoice generation, so now it should be fully backward compatible.

Also I found that that solution didn't worked fine with Hebrew, so I also fixed it.

Note: for preparing test data I used some sample data generation service.

Related Pull Requests

Fixed Issues (if relevant)

1. Arabic invoice pdf issue Magento 2.3.0 showing as Arabic letters but not correct  #25769

Manual testing scenarios (*)

1. See Arabic invoice pdf issue Magento 2.3.0 showing as Arabic letters but not correct  #25769

Questions or comments

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• All automated tests passed successfully (all builds are green)

[m2-assistant]

Hi @ihor-sviziev. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento give me test instance - deploy test instance based on PR changes
• @magento give me 2.4-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

[lbajsarowicz]

Looks fine, nice catch ✔️

[magento-engcom-team]

Hi @lbajsarowicz, thank you for the review.
ENGCOM-7465 has been created to process this Pull Request
✳️ @lbajsarowicz, could you please add one of the following labels to the Pull Request?

Label	Description
Auto-Tests: Covered	All changes in Pull Request is covered by auto-tests
Auto-Tests: Not Covered	Changes in Pull Request requires coverage by auto-tests
Auto-Tests: Not Required	Changes in Pull Request does not require coverage by auto-tests

[engcom-Delta]

✔️ QA passed
Was used phrase الإسم ابو بدر المطيري for all input fields
Before:

الإسم ابو بدر المطيري from admin side invoice not equal with يريطملا ردب وبا مسإلا from invoice pdf

After:

الإسم ابو بدر المطيري form admin side invoice is equal with الإسم ابو بدر المطيري from invoice pdf

[m2-assistant]

Hi @ihor-sviziev, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

[zezooo2]

@ihor-sviziev thank you i used your fix and it already make the text be from right to left but the words are separated ?!
like أ ح م د
it must be أحمد
any help on that ? (magento 2.3.2)
thanx alot

[ihor-sviziev]

O> @ihor-sviziev thank you i used your fix and it already make the text be from right to left but the words are separated ?!

like أ ح م د

it must be أحمد

any help on that ? (magento 2.3.2)

thanx alot

As I said above - with the current library, we can't fix it. We need to use another library for that. So far, it's quite a significant effort to implement it.

You could try to install some custom extension like https://store.fooman.co.nz/magento-extension-pdf-customiser-m2.html
Maybe it will fix the issue for you.

[zezooo2]

@ihor-sviziev thanks alot i will try 👍