-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MFTF: Add <magentoCron
instruction - CatalogImportExport / CatalogInventory / CatalogRule
#27323
MFTF: Add <magentoCron
instruction - CatalogImportExport / CatalogInventory / CatalogRule
#27323
Conversation
Hi @lbajsarowicz. Thank you for your contribution
For more details, please, review the Magento Contributor Guide documentation. |
…nto-catalog-import-inventory-rule # Conflicts: # app/code/Magento/CatalogRule/Test/Mftf/Test/AdminCreateCatalogPriceRuleTest.xml # app/code/Magento/CatalogRule/Test/Mftf/Test/AdminDeleteCatalogPriceRuleEntityTest/AdminDeleteCatalogPriceRuleEntityFromConfigurableProductTest.xml
…import-inventory-rule' into mftf-cron/magento-catalog-import-inventory-rule
@magento run all tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wow... now we have too many conflicts here. Could you resolve conflict?
…nto-catalog-import-inventory-rule # Conflicts: # app/code/Magento/CatalogImportExport/Test/Mftf/Test/AdminExportBundleProductTest.xml # app/code/Magento/CatalogImportExport/Test/Mftf/Test/AdminExportGroupedProductWithSpecialPriceTest.xml # app/code/Magento/CatalogImportExport/Test/Mftf/Test/AdminExportImportConfigurableProductWithImagesTest.xml # app/code/Magento/CatalogImportExport/Test/Mftf/Test/AdminExportSimpleAndConfigurableProductsWithCustomOptionsTest.xml # app/code/Magento/CatalogImportExport/Test/Mftf/Test/AdminExportSimpleProductAndConfigurableProductsWithAssignedImagesTest.xml # app/code/Magento/CatalogImportExport/Test/Mftf/Test/AdminExportSimpleProductAssignedToMainWebsiteAndConfigurableProductAssignedToCustomWebsiteTest.xml # app/code/Magento/CatalogImportExport/Test/Mftf/Test/AdminExportSimpleProductWithCustomAttributeTest.xml # app/code/Magento/CatalogInventory/Test/Mftf/Test/AdminCreateProductWithZeroMaximumQtyAllowedInShoppingCartTest.xml # app/code/Magento/CatalogRule/Test/Mftf/Test/AdminApplyCatalogRuleByCategoryTest.xml # app/code/Magento/CatalogRule/Test/Mftf/Test/ApplyCatalogRuleForSimpleProductForNewCustomerGroupTest.xml # app/code/Magento/CatalogRule/Test/Mftf/Test/ApplyCatalogRuleForSimpleProductWithCustomOptionsTest.xml
@magento run all tests |
@magento run Functional Tests B2B, Functional Tests CE, Functional Tests EE |
I'm going to help with review of the failures, as there can be some hidden dependency on other cron group than just index |
@magento run all tests |
…import-inventory-rule' into mftf-cron/magento-catalog-import-inventory-rule
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unit test failures are not related to changes from this PR
Hi @ihor-sviziev, thank you for the review. |
Notice: QA not applicable |
@magento run Unit Tests |
…rt / CatalogInventory / CatalogRule #27323
Hi @lbajsarowicz, thank you for your contribution! |
Description (*)
Adding
<magentoCron
which triggers partial reindex to have the created products in the index.That should fix most of the issues related to false-negatives in Functional Tests.
Related Pull Requests
Fixed Issues (if relevant)
Manual testing scenarios (*)
Questions or comments
Contribution checklist (*)