FIX #14080 Added improvements to Category repository (save method)

[sergiy-v]

Description

Added improvements to category repository (save method) to fix level issue.

Fixed Issues (if relevant)

#14080

Manual testing scenarios

See #14080 issue description for details.

Contribution checklist

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• All automated tests passed successfully (all builds are green)

[m2-assistant]

Hi @sergiy-v. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento give me test instance - deploy test instance based on PR changes
• @magento give me 2.4-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

[lbajsarowicz]

Related PR #27291

[sergiy-v]

@magento run all tests

[eduard13]

@magento run all tests

[sergiy-v]

@eduard13 PR is ready to review, the functional tests errors are not related to the changes.
Thank you.

[magento-engcom-team]

Hi @lbajsarowicz, thank you for the review.
ENGCOM-7112 has been created to process this Pull Request
✳️ @lbajsarowicz, could you please add one of the following labels to the Pull Request?

Label	Description
Auto-Tests: Covered	All changes in Pull Request is covered by auto-tests
Auto-Tests: Not Covered	Changes in Pull Request requires coverage by auto-tests
Auto-Tests: Not Required	Changes in Pull Request does not require coverage by auto-tests

[lbajsarowicz]

@sergiy-v I really like the fact that you covered that change with MFTF tests. However (!) I'm not sure if it's the best approach to cover that kind of change. What I mean is that in this specific case Integration Tests would give cleaner overview what is happening under the hood.

Thanks once again for well-done Functional Test.

[sergiy-v]

@sergiy-v I really like the fact that you covered that change with MFTF tests. However (!) I'm not sure if it's the best approach to cover that kind of change. What I mean is that in this specific case Integration Tests would give cleaner overview what is happening under the hood.

Thanks once again for well-done Functional Test.

@lbajsarowicz Thanks for your thoughts, will keep it in mind next time)

[magento-engcom-team]

Hi @eduard13, thank you for the review.
ENGCOM-7112 has been created to process this Pull Request
✳️ @eduard13, could you please add one of the following labels to the Pull Request?

Label	Description
Auto-Tests: Covered	All changes in Pull Request is covered by auto-tests
Auto-Tests: Not Covered	Changes in Pull Request requires coverage by auto-tests
Auto-Tests: Not Required	Changes in Pull Request does not require coverage by auto-tests

[engcom-Alfa]

Hi, @sergiy-v

During testing, we faced the issue.

Problem: The category is saved with the wrong url_path

Manual testing scenario:
1. Create any category on the second level (with parent_id =2).
Name: Test category 1, Url key: test-category-1.
2. Create subcategory in "Test category 2" with level = 2 by rest api:
/V1/categories

{
	"category": {
		"name": "Test category 2",
		"parent_id":"3",  /* Test category 1 */
		"is_active":"true",
		"include_in_menu": true,
		"level":"2",
		"custom_attributes": [{ "attribute_code": "url_key", "value": "test-category-2" }]
	}
}

Actual Result:
✖️ Now we have the url_key: "test-category-2" and path: "test-category-2"

Expected Result:
✔️ The url_path should be "/test-category-1/test-category-2"

3. Change the URL key of the Test category 2 either in the backend or via the api to something like "test-category-2-changed"

Actual Result:

✖️ Category "Test category 2" has attribute values:
url_key: "test-category-2-changed"
url_path: "test-category-2-changed"

Or Am I wrong?

@sergiy-v Could you take a look?

Thanks!

[engcom-Alfa]

@sergiy-v Thank you for the clarification!
I checked again and everything works correctly.
Thanks!

[engcom-Alfa]

@lbajsarowicz @eduard13 Could you approve again?
Thank you!

[magento-engcom-team]

Hi @eduard13, thank you for the review.
ENGCOM-7112 has been created to process this Pull Request

[engcom-Alfa]

✔️ QA Passed

Before:

After:

[lbajsarowicz]

✔️ Thank you for your contribution.

[magento-engcom-team]

Hi @lbajsarowicz, thank you for the review.
ENGCOM-7112 has been created to process this Pull Request

[engcom-Echo]

Failed functional tests not related to the changes in this PR

[m2-assistant]

Hi @sergiy-v, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.