Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

25668 Store code validation regex doesn't support uppercase letters #27248

Closed

Conversation

Usik2203
Copy link
Contributor

Description (*)

Fixed issue #25668: Magento 2 Store Code validation regex: doesn't support uppercase letters in scope code
Screenshot 2020-03-11 at 18 14 05

Related Pull Requests

Fixed Issues (if relevant)

  1. Magento 2 Store Code validation regex: doesn't support uppercase letters in scope code #25668: Magento 2 Store Code validation regex: doesn't support uppercase letters in scope code

Manual testing scenarios (*)

  1. ...
  2. ...

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@m2-assistant
Copy link

m2-assistant bot commented Mar 11, 2020

Hi @Usik2203. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

@magento-engcom-team magento-engcom-team added Component: App Release Line: 2.4 Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner labels Mar 11, 2020
@Usik2203 Usik2203 requested a review from eduard13 April 1, 2020 09:39
@ihor-sviziev ihor-sviziev self-assigned this Apr 2, 2020
@ihor-sviziev
Copy link
Contributor

Hi @Usik2203,

Unfortunately it's not clear what the use-case there could be. Asked for explanation in the issue report: #25668 (comment)

For now this PR is on hold

@ihor-sviziev
Copy link
Contributor

Hi,
I’m closing this PR as original issue was closed. More details #25668 (comment)

@m2-assistant
Copy link

m2-assistant bot commented Apr 3, 2020

Hi @Usik2203, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: App Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner Progress: on hold Release Line: 2.4
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants