-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FIX: responsiveness for images #27041
FIX: responsiveness for images #27041
Conversation
Hi @GrimLink. Thank you for your contribution
For more details, please, review the Magento Contributor Guide documentation. |
Hi @krzksz, thank you for the review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@GrimLink Please, see my review comment. Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good call, looks great!
Hi @krzksz, thank you for the review. |
✔️ QA Passed |
Hi @GrimLink, thank you for your contribution! |
Description (*)
Since Magento 2.3.4 (commit d0ad63c) the height auto has been removed.
this clearly was not tested as all images on on the Magento front-end break and are distorted thanks to the size.
Fixed Issues (if relevant)
Fixes: #27040
Manual testing scenarios (*)
Setup a Magento site with version 2.3.4 or higher
Create a CSS change containing the following CSS:
This will fix the issue at hand.
The change off course is fixed at the reset styles.
Where in the previous version this solution was.
Before the change from commit d0ad63c
Contribution checklist (*)