Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#26847: Added 'enterKey' event handler to prompt widget #27029

Conversation

sergiy-v
Copy link
Contributor

Description

Added event handler for enter key to the prompt widget in order to do 'confirm' action by hitting enter key.

Fixed Issues

  1. Hitting enter on create folder in media gallery refreshes the page #26847

Manual testing scenarios

See issue description from #26847.

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@m2-assistant
Copy link

m2-assistant bot commented Feb 26, 2020

Hi @sergiy-v. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

@magento-engcom-team magento-engcom-team added Area: Frontend Component: Cms Component: Ui Release Line: 2.4 Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner labels Feb 26, 2020
@dmytro-ch dmytro-ch self-assigned this Feb 26, 2020
@sergiy-v sergiy-v force-pushed the 26847-prompt-widget-add-enter-event-handler branch from 6ccac62 to 91908ee Compare February 26, 2020 14:51
dmytro-ch
dmytro-ch previously approved these changes Feb 26, 2020
@magento-engcom-team
Copy link
Contributor

Hi @dmytro-ch, thank you for the review.
ENGCOM-6993 has been created to process this Pull Request

Copy link
Contributor

@engcom-Alfa engcom-Alfa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @sergiy-v.

During testing, we faced the issue.

Problem: The folder is saved even when you press "Esc"

Manual testing scenario:

  1. Log in to Admin;
  2. Go to Catalog->Categories;
  3. Go to Content tab and click on Select from Gallery button;
  4. Click on Create Folder button;
  5. Fill field and click the "Enter" button on the keyboard

Actual Result: ✔️ The folder has been saved

  1. Click on Create Folder button again;
  2. Fill field and click the "Esc" button on the keyboard;

Actual Result:

✖️ The folder was saved at the click of the "Esc" button
after

@sergiy-v Could you take a look?

Thanks!

@ghost ghost dismissed dmytro-ch’s stale review February 28, 2020 07:56

Pull Request state was updated. Re-review required.

@sergiy-v
Copy link
Contributor Author

@engcom-Alfa thank you for details, I'll check it.

@engcom-Echo engcom-Echo self-assigned this Feb 28, 2020
@sergiy-v sergiy-v force-pushed the 26847-prompt-widget-add-enter-event-handler branch from 91908ee to f5b4ff9 Compare March 2, 2020 08:59
@sergiy-v sergiy-v force-pushed the 26847-prompt-widget-add-enter-event-handler branch from f5b4ff9 to 21afe21 Compare March 3, 2020 10:09
@sergiy-v
Copy link
Contributor Author

sergiy-v commented Mar 3, 2020

@engcom-Alfa nice catch!)
@dmytro-ch please check the changes once you will have a chance.
Thanks.

@magento-engcom-team
Copy link
Contributor

Hi @dmytro-ch, thank you for the review.
ENGCOM-6993 has been created to process this Pull Request

@engcom-Alfa
Copy link
Contributor

✔️ QA Passed

@eduard13
Copy link
Contributor

eduard13 commented Mar 9, 2020

@magento give me test instance

@magento-engcom-team
Copy link
Contributor

Hi @eduard13. Thank you for your request. I'm working on Magento instance for you

@magento-engcom-team
Copy link
Contributor

Hi @eduard13, here is your new Magento instance.
Admin access: https://pr-27029.instances.magento-community.engineering/admin_cd7e
Login: 78ebeb15 Password: ef7a337748e5
Instance will be terminated in up to 3 hours.

@m2-assistant
Copy link

m2-assistant bot commented Mar 12, 2020

Hi @sergiy-v, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants