-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#26847: Added 'enterKey' event handler to prompt widget #27029
#26847: Added 'enterKey' event handler to prompt widget #27029
Conversation
Hi @sergiy-v. Thank you for your contribution
For more details, please, review the Magento Contributor Guide documentation. |
6ccac62
to
91908ee
Compare
Hi @dmytro-ch, thank you for the review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @sergiy-v.
During testing, we faced the issue.
Problem: The folder is saved even when you press "Esc"
Manual testing scenario:
- Log in to Admin;
- Go to Catalog->Categories;
- Go to Content tab and click on Select from Gallery button;
- Click on Create Folder button;
- Fill field and click the "Enter" button on the keyboard
Actual Result: ✔️ The folder has been saved
- Click on Create Folder button again;
- Fill field and click the "Esc" button on the keyboard;
Actual Result:
✖️ The folder was saved at the click of the "Esc" button
@sergiy-v Could you take a look?
Thanks!
Pull Request state was updated. Re-review required.
@engcom-Alfa thank you for details, I'll check it. |
91908ee
to
f5b4ff9
Compare
f5b4ff9
to
21afe21
Compare
@engcom-Alfa nice catch!) |
Hi @dmytro-ch, thank you for the review. |
✔️ QA Passed |
@magento give me test instance |
Hi @eduard13. Thank you for your request. I'm working on Magento instance for you |
Hi @eduard13, here is your new Magento instance. |
Hi @sergiy-v, thank you for your contribution! |
Description
Added event handler for enter key to the prompt widget in order to do 'confirm' action by hitting enter key.
Fixed Issues
Manual testing scenarios
See issue description from #26847.
Contribution checklist