-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
issue-#25675 Added fix for #25675 issue to the 2.4 Magento version #26650
issue-#25675 Added fix for #25675 issue to the 2.4 Magento version #26650
Conversation
Hi @molneek. Thank you for your contribution
For more details, please, review the Magento Contributor Guide documentation. |
@dmytro-ch |
Hi @molneek. The |
Hi @rogyar. So in this case, does it mean that all these tests "Functional Tests B2B, Functional Tests CE, Functional Tests EE and Static Tests" are not related to my changes? |
@magento run all tests |
Hello @rogyar, seems like all tests passed |
/** | ||
* @var int | ||
*/ | ||
private $itemQtyTestValue; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a hint for the future. If we don't need to share value between different methods, there's no need to create an additional class property. You may use just local variables inside of the methods.
So $this->itemQtyTestValue
will be simply $itemQtyTestValue
inside of every method (test) of the current class
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rogyar Thank you, I agree, I had some ideas about using it, but then changed my mind and just used this as this is already created
Hi @rogyar, thank you for the review.
|
✔️ QA Passed An order could be created and proceed without any errors if the product quantity is 1 |
Hi @molneek, thank you for your contribution! |
Description
This pull request should fix issue #25675 in Magento 2.4
Fixed Issues
#25675: Unable add product to cart in Magento 2.3.3 backend when stock quantity is 1 - "The requested qty is not available"
Manual testing scenarios
Described here #25675