Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#26473: Improved logic for product image updating for configurable products #26560

Merged
merged 1 commit into from
Mar 19, 2020
Merged

#26473: Improved logic for product image updating for configurable products #26560

merged 1 commit into from
Mar 19, 2020

Conversation

sergiy-v
Copy link
Contributor

@sergiy-v sergiy-v commented Jan 28, 2020 •
edited
Loading

Description

Improved logic for product image updating (gallery data updating) for configurable products.

Fixed Issues

  1. BUG: Wrong selected product image when query url param configurable product #26473
  2. Wrong gallery main image and active preview after updating for configurable products. #26856
  3. Wrong gallery behavior when query url param configurable product #26858

Manual testing scenarios

See issue description from #26473 and this comment.
See issue description from #26856.
See issue description from #26858.

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@sergiy-v sergiy-v requested a review from DrewML as a code owner January 28, 2020 09:27
@m2-assistant
Copy link

m2-assistant bot commented Jan 28, 2020

Hi @sergiy-v. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

@magento-engcom-team magento-engcom-team added Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner labels Jan 28, 2020
@sergiy-v
Copy link
Contributor Author

Working on fixes for tests.

@dmytro-ch dmytro-ch self-assigned this Feb 13, 2020
@dmytro-ch dmytro-ch changed the title #26473: Improved logic for product image updating for configurable products [WIP] #26473: Improved logic for product image updating for configurable products Feb 13, 2020
@sergiy-v sergiy-v force-pushed the 26473-configurable-product-gallery-data-updating-improvements branch from 77abdf8 to 7c1e3bf Compare February 13, 2020 17:32
@dmytro-ch dmytro-ch changed the title [WIP] #26473: Improved logic for product image updating for configurable products #26473: Improved logic for product image updating for configurable products Feb 14, 2020
@dmytro-ch dmytro-ch added Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests Award: bug fix Award: special achievement labels Feb 16, 2020
@dmytro-ch
Copy link
Contributor

@sergiy-v, great job! Thank you for the fixes.
Would you mind to cover the aforementioned cases by autotests?

@sergiy-v
Copy link
Contributor Author

@sergiy-v, great job! Thank you for the fixes.
Would you mind to cover the aforementioned cases by autotests?

@dmytro-ch thanks for review, working on tests.

@sergiy-v
Copy link
Contributor Author

The tests has been added.
#26856: StorefrontConfigurableOptionsThumbImagesTest, StorefrontConfigurableSwatchOptionsThumbImagesTest.
#26473: StorefrontSelectedByQueryParamsConfigurableOptionsThumbImagesTest.
#26858: StorefrontSelectedByQueryParamsConfigurableSwatchOptionsThumbImagesTest.

@dmytro-ch please check it once you will have a chance.

@dmytro-ch dmytro-ch added Auto-Tests: Covered All changes in Pull Request is covered by auto-tests Award: MFTF test coverage Award: category of expertise and removed Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests labels Feb 26, 2020
@magento-engcom-team
Copy link
Contributor

Hi @dmytro-ch, thank you for the review.
ENGCOM-6992 has been created to process this Pull Request

@dmytro-ch
Copy link
Contributor

@sergiy-v, thank you for the updates!
Could you please squash all commits into a single one in order to clean up history?

fixed 'wrong image gallery', 'wrong gallery behavior when query url' …
54f93e2 
…for swatches, 'product image updating' for dropdown type, added MFTF tests to cover all cases: magento#26473, magento#26856, magento#26858
@sergiy-v sergiy-v force-pushed the 26473-configurable-product-gallery-data-updating-improvements branch from 2a042dc to 54f93e2 Compare February 28, 2020 07:03
@sergiy-v
Copy link
Contributor Author

@sergiy-v, thank you for the updates!
Could you please squash all commits into a single one in order to clean up history?

@dmytro-ch I have cleaned up the commit story. Thanks.

@magento-engcom-team
Copy link
Contributor

Hi @dmytro-ch, thank you for the review.
ENGCOM-6992 has been created to process this Pull Request

@engcom-Alfa engcom-Alfa self-assigned this Mar 11, 2020
@engcom-Alfa
Copy link
Contributor

✔️ QA Passed

@engcom-Charlie engcom-Charlie self-assigned this Mar 11, 2020
This was linked to issues Mar 13, 2020
BUG: Wrong selected product image when query url param configurable product #26473
Closed
Wrong gallery main image and active preview after updating for configurable products. #26856
Closed
Wrong gallery behavior when query url param configurable product #26858
Closed
@slavvka
Copy link
Member

slavvka commented Mar 15, 2020

@magento run Functional Tests EE

This was referenced Mar 19, 2020
Closed
Closed
Closed
magento-engcom-team pushed a commit that referenced this pull request Mar 19, 2020
@slavvka
ENGCOM-6992: #26473: Improved logic for product image updating for co…
ae84d13 
…nfigurable products #26560
@magento-engcom-team magento-engcom-team merged commit 7f0119e into magento:2.4-develop Mar 19, 2020
@m2-assistant
Copy link

m2-assistant bot commented Mar 19, 2020

Hi @sergiy-v, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@sdzhepa sdzhepa mentioned this pull request May 9, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmytro-ch dmytro-ch dmytro-ch approved these changes

@DrewML DrewML Awaiting requested review from DrewML

Assignees

@dmytro-ch dmytro-ch

@engcom-Alfa engcom-Alfa

@engcom-Charlie engcom-Charlie

Labels
Area: Frontend Area: Lib/Frontend Auto-Tests: Covered All changes in Pull Request is covered by auto-tests Award: bug fix Award: category of expertise Award: MFTF test coverage Award: special achievement Component: Catalog Component: ConfigurableProduct Component: Swatches Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner Progress: accept Release Line: 2.4
Projects
None yet
Milestone
No milestone
7 participants
@sergiy-v @dmytro-ch @magento-engcom-team @engcom-Alfa @slavvka @engcom-Charlie @engcom-Echo