Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

{ASI} :- Error message to be cached for grid data storage component #26502

Merged
merged 10 commits into from
Feb 13, 2020
Merged

{ASI} :- Error message to be cached for grid data storage component #26502

Show file tree
Hide file tree
Changes from 8 commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
c9d5e8e
Error message to becached for grid data storage component
konarshankar07 Jan 22, 2020
8357cf8
Jasmine test added for initConfig, getByIds, getRequestData, cacheReq…
konarshankar07 Jan 23, 2020
a17c2a5
More jasmine tests added
konarshankar07 Jan 26, 2020
7fafb2d
More method cover with jasmine tests
konarshankar07 Feb 1, 2020
9de1e59
Fixed static tests
konarshankar07 Feb 1, 2020
c3ba2ce
improve test names
konarshankar07 Feb 6, 2020
0aef9ad
feedback changes
konarshankar07 Feb 7, 2020
7ef0c88
magento/magento2#26502: Code review changes
sivaschenko Feb 9, 2020
a1d2a84
Fixed static tests
konarshankar07 Feb 10, 2020
1f2ed90
code cleanup
konarshankar07 Feb 10, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions app/code/Magento/Ui/view/base/web/js/grid/data-storage.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -188,7 +188,8 @@ define([

result = {
items: this.getByIds(request.ids),
totalRecords: request.totalRecords
totalRecords: request.totalRecords,
errorMessage: request.errorMessage
};

delay ?
Expand Down Expand Up @@ -216,7 +217,8 @@ define([
this._requests.push({
ids: this.getIds(data.items),
params: params,
totalRecords: data.totalRecords
totalRecords: data.totalRecords,
errorMessage: data.errorMessage
});

return this;
Expand Down
Loading