Fix #25761: Site map doesn't include home page #26445

deepaksnair · 2020-01-18T08:57:39Z

Description (*)

Site map doesn't include home page url issue fixed

Fixed Issues (if relevant)

Site map doesn't include home page #25761: Site map doesn't include home page

Manual testing scenarios (*)

Go to Stores > Settings > Configuration > Catalog > XML Sitemap > Generation Settings section
Change option Enabled to Yes
Go to Marketing > Seo & Search > Site Map
Create a new site map and generate
Open new site map in browser

Questions or comments

Contribution checklist (*)

Pull request has a meaningful description of its purpose
All commits are accompanied by meaningful commit messages
All new or changed code is covered with unit/integration tests (if applicable)
All automated tests passed successfully (all builds are green)

m2-assistant · 2020-01-18T08:57:42Z

Hi @deepaksnair. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

@magento give me test instance - deploy test instance based on PR changes
@magento give me 2.4-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

deepaksnair · 2020-01-18T09:10:23Z

@magento give me test instance

deepaksnair · 2020-01-18T09:25:42Z

@magento give me 2.4-develop instance

lbajsarowicz

Could you provide automated tests to the PR?

lbajsarowicz · 2020-01-18T15:43:02Z

app/code/Magento/Sitemap/etc/adminhtml/system.xml

-            <group id="generate" translate="label" type="text" sortOrder="4" showInDefault="1">
+            <group id="store" translate="label" type="text" sortOrder="4" showInDefault="1" showInWebsite="1" showInStore="1">
+                <label>Store Url Options</label>
+                <field id="changefreq" translate="label" type="select" sortOrder="1" showInDefault="1" showInWebsite="1" showInStore="1" canRestore="1">


Good practice is to increase sortOrder numbers by 10. This way extension developers are still able to extend the grid with their elements.

@lbajsarowicz , thanks for reveiwing PR, I have updated the sort orders. Please help to verify.
Also can you please suggest how can I provide automated tests to PR.

magento-engcom-team · 2020-01-21T19:58:10Z

Hi @deepaksnair. Thank you for your request. I'm working on Magento instance for you

magento-engcom-team · 2020-01-21T19:58:11Z

Hi @deepaksnair. Thank you for your request. I'm working on Magento 2.4-develop instance for you

magento-engcom-team · 2020-01-21T19:58:46Z

Hi @deepaksnair, here is your Magento instance.
Admin access: https://i-26445-2-4-develop.instances.magento-community.engineering/admin_b6fe
Login: 2d937ef6 Password: e0524ea52c83
Instance will be terminated in up to 3 hours.

deepaksnair · 2020-01-23T06:27:49Z

Hello @lbajsarowicz , I have added automated test cases in last commit, please help to verify PR.
Thanks

lbajsarowicz

Great job! Only a few things to be changed.

lbajsarowicz · 2020-01-23T09:21:39Z

app/code/Magento/Sitemap/Test/Unit/Model/ItemProvider/StoreUrlTest.php

+    }
+
+    /**
+     * @return \PHPUnit_Framework_MockObject_MockObject


Use \PHPUnit\Framework\MockObject\MockObject

And return type is actually:
SitemapItemInterfaceFactory|MockObject

lbajsarowicz · 2020-01-23T09:22:32Z

app/code/Magento/Sitemap/Test/Unit/Model/ItemProvider/StoreUrlTest.php

+    }
+
+    /**
+     * @return \PHPUnit_Framework_MockObject_MockObject


Use \PHPUnit\Framework\MockObject\MockObject
And return type is ConfigReaderInterface|MockObject

lbajsarowicz · 2020-01-23T09:23:06Z

app/code/Magento/Sitemap/Test/Unit/Model/ItemProvider/StoreUrlTest.php

+use Magento\Sitemap\Model\SitemapItem;
+use Magento\Sitemap\Model\SitemapItemInterfaceFactory;
+
+class StoreUrlTest extends \PHPUnit\Framework\TestCase


Import class.

lbajsarowicz · 2020-01-23T09:23:57Z

app/code/Magento/Sitemap/Test/Unit/Model/ItemProvider/StoreUrlTest.php

+        $resolver = new StoreUrlItemResolver($configReaderMock, $itemFactoryMock);
+        $items = $resolver->getItems(1);
+
+        $this->assertTrue(count($items) == 1);


There is ->assertCount(1, $items)

lbajsarowicz · 2020-01-23T09:25:06Z

app/code/Magento/Sitemap/Model/ItemProvider/StoreUrlConfigReader.php

+    }
+
+    /**
+     * {@inheritdoc}


@inheritdoc should not be in braces

lbajsarowicz · 2020-01-23T09:25:14Z

app/code/Magento/Sitemap/Model/ItemProvider/StoreUrlConfigReader.php

+    }
+
+    /**
+     * {@inheritdoc}


@inheritdoc should not be in braces

deepaksnair · 2020-01-23T12:51:10Z

Hello @lbajsarowicz , I have resolved all the feedback given by you, please help to review it again.
Thanks.

magento-engcom-team · 2020-01-23T13:14:33Z

Hi @lbajsarowicz, thank you for the review.
ENGCOM-6670 has been created to process this Pull Request
✳️ @lbajsarowicz, could you please add one of the following labels to the Pull Request?

Label	Description
`Auto-Tests: Covered`	All changes in Pull Request is covered by auto-tests
`Auto-Tests: Not Covered`	Changes in Pull Request requires coverage by auto-tests
`Auto-Tests: Not Required`	Changes in Pull Request does not require coverage by auto-tests

engcom-Alfa · 2020-01-24T12:06:37Z

Hi @deepaksnair, thank you for your contribution.

Could you fix failing static tests and add this phrase Store Url Options into the translation file?

Thanks!

lbajsarowicz · 2020-01-25T00:47:43Z

@deepaksnair Please fix Static Tests.
I'd love to help you with Automated tests - call me on Community Engineering Slack, please.

deepaksnair · 2020-01-27T13:59:58Z

Hello @lbajsarowicz , @engcom-Alfa , I have resolved the issues in Static Tests also added translations, please help to verify.
Thanks

magento-engcom-team · 2020-01-28T08:41:41Z

Hi @lbajsarowicz, thank you for the review.
ENGCOM-6670 has been created to process this Pull Request

engcom-Alfa · 2020-01-28T09:30:09Z

✔️ QA Passed

m2-assistant · 2020-02-07T23:15:16Z

Hi @deepaksnair, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

fixed issue magento#25761

3bffb4c

deepaksnair requested a review from paliarush as a code owner January 18, 2020 08:57

lbajsarowicz suggested changes Jan 18, 2020

View reviewed changes

ghost assigned lbajsarowicz Jan 18, 2020

ghost added the Progress: needs update label Jan 18, 2020

update sort order

57b8f53

deepaksnair requested a review from lbajsarowicz January 20, 2020 06:12

fixed magento#25761 - added automated test cases

f165a53

fixed magento#25761 - update test case and one comment

8f5b2c7

lbajsarowicz suggested changes Jan 23, 2020

View reviewed changes

lbajsarowicz changed the title ~~fixed issue #25761~~ Fix #25761: Site map doesn't include home page Jan 23, 2020

fix magento#25761 - resolved feedbacks

d93fe31

deepaksnair requested a review from lbajsarowicz January 23, 2020 12:51

lbajsarowicz approved these changes Jan 23, 2020

View reviewed changes

ghost added Progress: ready for testing and removed Progress: needs update labels Jan 23, 2020

magento-engcom-team added Release Line: 2.4 Partner: Ranosys Technologies partners-contribution Pull Request is created by Magento Partner Component: Sitemap labels Jan 23, 2020

engcom-Alfa self-assigned this Jan 24, 2020

ghost added Progress: testing in progress and removed Progress: ready for testing labels Jan 24, 2020

engcom-Alfa added the Auto-Tests: Covered All changes in Pull Request is covered by auto-tests label Jan 24, 2020

ghost added Progress: needs update and removed Progress: testing in progress labels Jan 24, 2020

fix-25761 : resolved static test issues and added translation

dec8972

lbajsarowicz approved these changes Jan 28, 2020

View reviewed changes

ghost added Progress: ready for testing and removed Progress: needs update labels Jan 28, 2020

ghost added Progress: testing in progress and removed Progress: ready for testing labels Jan 28, 2020

ghost added Progress: extended testing and removed Progress: testing in progress labels Jan 28, 2020

engcom-Charlie self-assigned this Jan 28, 2020

ghost added Progress: accept and removed Progress: extended testing labels Jan 28, 2020

magento-engcom-team added the Award: bug fix label Feb 4, 2020

slavvka mentioned this pull request Feb 7, 2020

Site map doesn't include home page #25761

Closed

magento-engcom-team pushed a commit that referenced this pull request Feb 7, 2020

ENGCOM-6670: Fix #25761: Site map doesn't include home page #26445

a7569a7

magento-engcom-team merged commit dec8972 into magento:2.4-develop Feb 7, 2020

sdzhepa mentioned this pull request May 9, 2022

tyutyu sdzhepa/magento2#5

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix #25761: Site map doesn't include home page #26445

Fix #25761: Site map doesn't include home page #26445

deepaksnair commented Jan 18, 2020 •

edited by lbajsarowicz

Loading

m2-assistant bot commented Jan 18, 2020

deepaksnair commented Jan 18, 2020

deepaksnair commented Jan 18, 2020

lbajsarowicz left a comment

lbajsarowicz Jan 18, 2020

deepaksnair Jan 20, 2020

magento-engcom-team commented Jan 21, 2020

magento-engcom-team commented Jan 21, 2020

magento-engcom-team commented Jan 21, 2020

deepaksnair commented Jan 23, 2020

lbajsarowicz left a comment

lbajsarowicz Jan 23, 2020

lbajsarowicz Jan 23, 2020

lbajsarowicz Jan 23, 2020

lbajsarowicz Jan 23, 2020

lbajsarowicz Jan 23, 2020

lbajsarowicz Jan 23, 2020

lbajsarowicz Jan 23, 2020

deepaksnair commented Jan 23, 2020

magento-engcom-team commented Jan 23, 2020

engcom-Alfa commented Jan 24, 2020

lbajsarowicz commented Jan 25, 2020

deepaksnair commented Jan 27, 2020

magento-engcom-team commented Jan 28, 2020

engcom-Alfa commented Jan 28, 2020

m2-assistant bot commented Feb 7, 2020

Fix #25761: Site map doesn't include home page #26445

Fix #25761: Site map doesn't include home page #26445

Conversation

deepaksnair commented Jan 18, 2020 • edited by lbajsarowicz Loading

Description (*)

Fixed Issues (if relevant)

Manual testing scenarios (*)

Questions or comments

Contribution checklist (*)

m2-assistant bot commented Jan 18, 2020

deepaksnair commented Jan 18, 2020

deepaksnair commented Jan 18, 2020

lbajsarowicz left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

magento-engcom-team commented Jan 21, 2020

magento-engcom-team commented Jan 21, 2020

magento-engcom-team commented Jan 21, 2020

deepaksnair commented Jan 23, 2020

lbajsarowicz left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

deepaksnair commented Jan 23, 2020

magento-engcom-team commented Jan 23, 2020

engcom-Alfa commented Jan 24, 2020

lbajsarowicz commented Jan 25, 2020

deepaksnair commented Jan 27, 2020

magento-engcom-team commented Jan 28, 2020

engcom-Alfa commented Jan 28, 2020

m2-assistant bot commented Feb 7, 2020

deepaksnair commented Jan 18, 2020 •

edited by lbajsarowicz

Loading