Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MFTF: Add missing tests annotations #26391

Merged

Conversation

lbajsarowicz
Copy link
Contributor

@lbajsarowicz lbajsarowicz commented Jan 14, 2020

Description (*)

Test Generation triggers tons of DEPRECATION notices
image

Fixed Issues (if relevant)

N/A

Related Pull Requests

#26391
https://github.com/magento/partners-magento2b2b/pull/40
https://github.com/magento/partners-magento2ee/pull/124

Manual testing scenarios (*)

  1. vendor/bin/mftf generate:tests
  2. You should see no notices.

Questions or comments

Same commit for EE and B2B submitted.

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@m2-assistant
Copy link

m2-assistant bot commented Jan 14, 2020

Hi @lbajsarowicz. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

@magento-engcom-team magento-engcom-team added Partner: Mediotype partners-contribution Pull Request is created by Magento Partner labels Jan 14, 2020
@lbajsarowicz lbajsarowicz requested a review from kokoc as a code owner January 14, 2020 22:50
@lbajsarowicz
Copy link
Contributor Author

@lbajsarowicz
Copy link
Contributor Author

Important: Do not merge before #26395 that is already merged to this branch.

@lbajsarowicz
Copy link
Contributor Author

@magento run all tests

@ihor-sviziev ihor-sviziev self-assigned this Jan 15, 2020
@ihor-sviziev ihor-sviziev added Award: bug fix Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests labels Jan 15, 2020
@magento-engcom-team
Copy link
Contributor

Hi @ihor-sviziev, thank you for the review.
ENGCOM-6620 has been created to process this Pull Request

@engcom-Alfa
Copy link
Contributor

✔️ QA Passed

@lenaorobei lenaorobei changed the base branch from 2.4-develop to 2.3 January 27, 2020 16:44
@lenaorobei lenaorobei changed the base branch from 2.3 to 2.4-develop January 27, 2020 16:44
@lenaorobei lenaorobei added Auto-Tests: Covered All changes in Pull Request is covered by auto-tests and removed Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests labels Jan 28, 2020
@magento-engcom-team magento-engcom-team merged commit 44dbbe1 into magento:2.4-develop Feb 3, 2020
@m2-assistant
Copy link

m2-assistant bot commented Feb 3, 2020

Hi @lbajsarowicz, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests Component: multiple Partner: Mediotype partners-contribution Pull Request is created by Magento Partner Progress: accept Release Line: 2.4
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants