Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#25300 Mobile view issue on category page - Sort By label overlaps #26381

Merged

Conversation

akartavtsev
Copy link
Contributor

@akartavtsev akartavtsev commented Jan 14, 2020

Description (*)

The changed margin of sorter for mobile view.

Fixed Issues (if relevant)

  1. Mobile view issue on category page - Sort By label overlaps with Shop By button #25300: Mobile view issue on category page - Sort By label overlaps with Shop By button

Manual testing scenarios (*)

  1. Create one category
  2. Assign 2, 3 products in the category.
  3. Now in mobile view open category page on frontend
    Note:
  • View category page in iPhone 5 or on 320px screen size.
  • If shop by option is not appearing on the category page then try to add more product and attribute in products to activate the layered navigation.

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@m2-assistant
Copy link

m2-assistant bot commented Jan 14, 2020

Hi @akartavtsev. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

@nuzil nuzil self-assigned this Jan 15, 2020
@nuzil
Copy link
Contributor

nuzil commented Jan 15, 2020

@magento give me test instance

@magento-engcom-team
Copy link
Contributor

Hi @nuzil. Thank you for your request. I'm working on Magento instance for you

@magento-engcom-team
Copy link
Contributor

Hi @nuzil, here is your new Magento instance.
Admin access: https://pr-26381.instances.magento-community.engineering/admin
Login: admin Password: 123123q

@nuzil nuzil added the Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests label Jan 15, 2020
@magento-engcom-team
Copy link
Contributor

Hi @nuzil, thank you for the review.
ENGCOM-6607 has been created to process this Pull Request

@magento-engcom-team
Copy link
Contributor

@akartavtsev thank you for contributing. Please accept Community Contributors team invitation here to gain extended permissions for this repository.

@engcom-Alfa
Copy link
Contributor

✔️ QA Passed

@m2-assistant
Copy link

m2-assistant bot commented Feb 7, 2020

Hi @akartavtsev, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@sdzhepa sdzhepa mentioned this pull request May 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Design/Frontend Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests Progress: accept Release Line: 2.4
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants