Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed Special Price class not added in configurable product page #26170

Merged
merged 2 commits into from
Dec 30, 2019
Merged

Fixed Special Price class not added in configurable product page #26170

merged 2 commits into from
Dec 30, 2019

Conversation

ravi-chandra3197
Copy link
Contributor

@ravi-chandra3197 ravi-chandra3197 commented Dec 24, 2019 •
edited
Loading

Description (*)

Fixed Special Price class not added in configurable product page

Fixed Issues (if relevant)

  1. Special Price class not added in configurable product page #24972: Special Price class not added in configurable product page Special Price class not added in configurable product page #24972

Manual testing scenarios (*)

  1. ...
  2. ...

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@m2-assistant
Copy link

m2-assistant bot commented Dec 24, 2019

Hi @ravi-chandra3197. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

@magento-engcom-team magento-engcom-team added Partner: Krish TechnoLabs partners-contribution Pull Request is created by Magento Partner labels Dec 24, 2019
lbajsarowicz
lbajsarowicz suggested changes Dec 24, 2019
View reviewed changes
app/code/Magento/Swatches/view/base/web/js/swatch-renderer.js Outdated
Comment on lines 954 to 958
if (isShow) {
$productPrice.find('span:first').addClass('special-price');
} else {
$productPrice.find('span:first').removeClass('special-price');
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In my opinion you can use toggleClass

https://api.jquery.com/toggleclass/

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @lbajsarowicz
I have update PR as per your suggestion
can you review it?

@ghost ghost assigned lbajsarowicz Dec 24, 2019
lbajsarowicz
lbajsarowicz approved these changes Dec 24, 2019
View reviewed changes
Copy link
Contributor

@lbajsarowicz lbajsarowicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@magento-engcom-team
Copy link
Contributor

Hi @lbajsarowicz, thank you for the review.
ENGCOM-6520 has been created to process this Pull Request
✳️ @lbajsarowicz, could you please add one of the following labels to the Pull Request?

Label Description
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests
Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests
Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests

@engcom-Delta engcom-Delta self-assigned this Dec 24, 2019
@engcom-Delta
Copy link
Contributor

✔️ QA passed

@engcom-Golf engcom-Golf self-assigned this Dec 26, 2019
@engcom-Golf engcom-Golf added the Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests label Dec 26, 2019
@engcom-Golf engcom-Golf added Auto-Tests: Covered All changes in Pull Request is covered by auto-tests and removed Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests labels Dec 26, 2019
@VladimirZaets VladimirZaets mentioned this pull request Dec 30, 2019
Closed
magento-engcom-team pushed a commit that referenced this pull request Dec 30, 2019
@VladimirZaets
ENGCOM-6520: Fixed Special Price class not added in configurable prod…
b596ffb 
…uct page #26170
@magento-engcom-team magento-engcom-team merged commit e037d51 into magento:2.4-develop Dec 30, 2019
@m2-assistant
Copy link

m2-assistant bot commented Dec 30, 2019

Hi @ravi-chandra3197, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@sdzhepa sdzhepa mentioned this pull request May 9, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lbajsarowicz lbajsarowicz lbajsarowicz approved these changes

@DrewML DrewML Awaiting requested review from DrewML

Assignees

@lbajsarowicz lbajsarowicz

@VladimirZaets VladimirZaets

@engcom-Delta engcom-Delta

@engcom-Golf engcom-Golf

Labels
Area: Frontend Auto-Tests: Covered All changes in Pull Request is covered by auto-tests Component: Swatches Partner: Krish TechnoLabs partners-contribution Pull Request is created by Magento Partner Progress: accept Release Line: 2.4
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@ravi-chandra3197 @magento-engcom-team @engcom-Delta @lbajsarowicz @VladimirZaets @engcom-Golf @Nazar65