Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Search] Cover SynonymActions Column by Unit Test #26076

Merged
merged 2 commits into from
Dec 19, 2019
Merged

[Search] Cover SynonymActions Column by Unit Test #26076

merged 2 commits into from
Dec 19, 2019

Conversation

edenduong
Copy link
Contributor

Description (*)

Increase Test Coverage

[Search] Cover SynonymActions Column by Unit Test

  • Test prepareDataSource() with data source has no item
  • Test prepareDataSource() with data source has items

Fixed Issues (if relevant)

Manual testing scenarios (*)

vendor/bin/phpunit app/code/Magento/Search/Test/Unit/Ui/Component/Listing/Column/SynonymActionsTest.php

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@edenduong edenduong requested a review from kokoc as a code owner December 17, 2019 10:14
@m2-assistant
Copy link

m2-assistant bot commented Dec 17, 2019

Hi @edenduong. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

@ghost ghost assigned lbajsarowicz Dec 17, 2019
@edenduong
Copy link
Contributor Author

Hi @lbajsarowicz : It is ok now. Thank you for your feedback. Please check it again.

lbajsarowicz
lbajsarowicz approved these changes Dec 18, 2019
View reviewed changes
Copy link
Contributor

@lbajsarowicz lbajsarowicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Thank you for your contribution. Well done!

app/code/Magento/Search/Test/Unit/Ui/Component/Listing/Column/SynonymActionsTest.php
Comment on lines +133 to +136
[
SynonymActions::SYNONYM_URL_PATH_DELETE, ['group_id' => self::STUB_SYNONYM_GROUP_ID],
sprintf(self::SYNONYM_GROUP_DELETE_URL, self::STUB_SYNONYM_GROUP_ID)
],
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According to PSR each element should be in separate line, however I understand the goal of having 2 : 1 set there.

@magento-engcom-team
Copy link
Contributor

Hi @lbajsarowicz, thank you for the review.
ENGCOM-6498 has been created to process this Pull Request
✳️ @lbajsarowicz, could you please add one of the following labels to the Pull Request?

Label Description
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests
Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests
Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests

@engcom-Alfa engcom-Alfa self-assigned this Dec 18, 2019
@engcom-Alfa engcom-Alfa added the Auto-Tests: Covered All changes in Pull Request is covered by auto-tests label Dec 18, 2019
@engcom-Alfa
Copy link
Contributor

✔️ QA Passed

@edenduong
Copy link
Contributor Author

@lbajsarowicz @engcom-Alfa: Could you please add "Test Coverage Award" for this PR :) Thanks :D

@engcom-Golf engcom-Golf self-assigned this Dec 18, 2019
magento-engcom-team pushed a commit that referenced this pull request Dec 19, 2019
@VladimirZaets
ENGCOM-6498: [Search] Cover SynonymActions Column by Unit Test #26076
c0854f5
@magento-engcom-team magento-engcom-team merged commit a77faf3 into magento:2.4-develop Dec 19, 2019
@m2-assistant
Copy link

m2-assistant bot commented Dec 19, 2019

Hi @edenduong, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lbajsarowicz lbajsarowicz lbajsarowicz approved these changes

@kokoc kokoc Awaiting requested review from kokoc

Assignees

@lbajsarowicz lbajsarowicz

@engcom-Alfa engcom-Alfa

@engcom-Golf engcom-Golf

Labels
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests Award: test coverage Component: Search Progress: accept Release Line: 2.4 tech-partners-contribution Technology Partner: Magestore
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@edenduong @magento-engcom-team @engcom-Alfa @lbajsarowicz @engcom-Golf