-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Resolve Admin panel is not accessible after limited permissions set to at least one admin account issue25881 #25909
Resolve Admin panel is not accessible after limited permissions set to at least one admin account issue25881 #25909
Conversation
…o at least one admin account issue25881
Hi @edenduong. Thank you for your contribution
For more details, please, review the Magento Contributor Guide documentation. |
@magento run all tests |
@magento run Database Compare |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @edenduong,
great job, thank you for your contribution!
Could you please cover your fix by either Integration or Functional test?
…881' into 2.3-bugfix/access_denied_issue25881
Hi @dmytro-ch: I have just covered it by MFTF. Please check it again. Thanks! |
@edenduong, thank you for the updates! |
f2958a8
to
2b9d6b3
Compare
2b9d6b3
to
f5db9f6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
MHI fail is not valid, the protected function is extending the parent function
Hi @sivaschenko, thank you for the review. |
✔️ QA Passed |
@engcom-Golf what was the reason of marking this PR as pending approval? |
@slavvka To approve failed Health index |
|
…issions set to at least one admin account issue25881 #25909
Hi @edenduong, thank you for your contribution! |
Description (*)
Fixed Issues (if relevant)
Manual testing scenarios (*)
Expected result
The new admin user is logged into the admin panel.
Other admin accounts are not affected.
Questions or comments
Contribution checklist (*)