Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve Admin panel is not accessible after limited permissions set to at least one admin account issue25881 #25909

Conversation

edenduong
Copy link
Contributor

Description (*)

  1. Resolve Admin panel is not accessible after limited permissions set to at least one admin account #25881: Admin panel is not accessible after limited permissions set to at least one admin account

Fixed Issues (if relevant)

  1. Admin panel is not accessible after limited permissions set to at least one admin account #25881: Admin panel is not accessible after limited permissions set to at least one admin account

Manual testing scenarios (*)

  • Login to admin panel
  • Go to System->User Roles
  • Create a new role:
  • In Role Resources check only Media Gallery
    image
  • Create a new admin user account and assign the created role to it
  • Log out from admin panel
  • Log in to admin panel as a newly created user
  • Log in to admin panel as an admin having full permissions

Expected result

The new admin user is logged into the admin panel.
Other admin accounts are not affected.

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@edenduong edenduong requested a review from paliarush as a code owner December 5, 2019 07:21
@m2-assistant
Copy link

m2-assistant bot commented Dec 5, 2019

Hi @edenduong. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

@dmytro-ch dmytro-ch self-assigned this Dec 5, 2019
@sidolov sidolov changed the base branch from 2.3-develop to 2.4-develop December 5, 2019 17:00
@slavvka
Copy link
Member

slavvka commented Dec 5, 2019

@magento run all tests

@slavvka
Copy link
Member

slavvka commented Dec 5, 2019

@magento run Database Compare

Copy link
Contributor

@dmytro-ch dmytro-ch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @edenduong,
great job, thank you for your contribution!
Could you please cover your fix by either Integration or Functional test?

@dmytro-ch dmytro-ch added the Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests label Dec 9, 2019
@edenduong
Copy link
Contributor Author

Hi @dmytro-ch:

I have just covered it by MFTF. Please check it again.

Thanks!

@dmytro-ch
Copy link
Contributor

@edenduong, thank you for the updates!

@dmytro-ch dmytro-ch added Auto-Tests: Covered All changes in Pull Request is covered by auto-tests Award: bug fix Award: MFTF test coverage and removed Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests labels Dec 9, 2019
@Nazar65 Nazar65 force-pushed the 2.3-bugfix/access_denied_issue25881 branch 3 times, most recently from f2958a8 to 2b9d6b3 Compare December 20, 2019 12:44
@Nazar65 Nazar65 force-pushed the 2.3-bugfix/access_denied_issue25881 branch from 2b9d6b3 to f5db9f6 Compare December 20, 2019 15:03
Copy link
Member

@sivaschenko sivaschenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

MHI fail is not valid, the protected function is extending the parent function

@magento-engcom-team
Copy link
Contributor

Hi @sivaschenko, thank you for the review.
ENGCOM-6433 has been created to process this Pull Request

@engcom-Alfa
Copy link
Contributor

✔️ QA Passed

@slavvka
Copy link
Member

slavvka commented Jan 9, 2020

@engcom-Golf what was the reason of marking this PR as pending approval?

@Nazar65
Copy link
Member

Nazar65 commented Jan 9, 2020

@slavvka To approve failed Health index

@slavvka
Copy link
Member

slavvka commented Jan 9, 2020

MHI fail is not valid, the protected function is extending the parent function

@m2-assistant
Copy link

m2-assistant bot commented Jan 17, 2020

Hi @edenduong, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@sdzhepa sdzhepa mentioned this pull request May 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Admin panel is not accessible after limited permissions set to at least one admin account
10 participants