Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix gallery thumbs navigation scrolling #25839

Conversation

iGerchak
Copy link
Contributor

@iGerchak iGerchak commented Nov 29, 2019

Description (*)

Currently, we can't scroll thumbs navigation in the gallery on the product page on all touch devices.
This PR fixes this issue

Fixed Issues (if relevant)

  1. Gallery Thumbnail (left/right) Scroll Performance Android Chrome Sluggish and Unresponsive #21014: Gallery Thumbnail (left/right) Scroll Performance Android Chrome Sluggish and Unresponsive

Preconditions (*)

Magento 2.3.2 | 2.3.3
Product with a lot of images in the gallery

Manual testing scenarios (*)

  1. Go to edit the file: app/design/frontend/Magento/luma/etc/view.xml
  2. Change navtype in the Magento_Catalog -> gallery from slides to thumbs
  3. Save changes and flush Magento cache
  4. Go to the frontend product page via mobile phone or tablet and try to scroll thumbs navigation

Expected result (*)

  1. Gallery thumbs navigation should be scrolled with Kinetic effect

Actual result (*)

  1. Gallery thumbs navigation scroll just a few pixels

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@iGerchak iGerchak requested a review from DrewML as a code owner November 29, 2019 10:51
@m2-assistant
Copy link

m2-assistant bot commented Nov 29, 2019

Hi @iGerchak. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

@ihor-sviziev ihor-sviziev added the Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests label Nov 29, 2019
@magento-engcom-team
Copy link
Contributor

Hi @ihor-sviziev, thank you for the review.
ENGCOM-6368 has been created to process this Pull Request

@ihor-sviziev
Copy link
Contributor

@krzksz I believe this docs just outdated and that's not true.
I'll discuss it with other maintainters.

@sidolov sidolov changed the base branch from 2.3-develop to 2.4-develop December 5, 2019 17:09
@ihor-sviziev
Copy link
Contributor

@slavvka could you point me should we support iOS 11 or not?

@slavvka
Copy link
Member

slavvka commented Dec 13, 2019

@slavvka could you point me should we support iOS 11 or not?

@ihor-sviziev I am still waiting for a response from PO

@ihor-sviziev
Copy link
Contributor

@slavvka any updates?

@slavvka
Copy link
Member

slavvka commented Jan 15, 2020

@ihor-sviziev Yes, PO approved that we support iPhone 6 and iOS 12, iOS 7 isn't supported anymore

Copy link
Contributor

@krzksz krzksz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work and a great news that we don't need to support iOS 11.

@magento-engcom-team
Copy link
Contributor

Hi @krzksz, thank you for the review.
ENGCOM-6368 has been created to process this Pull Request

@engcom-Delta
Copy link
Contributor

✔️ QA passed

@m2-assistant
Copy link

m2-assistant bot commented Feb 7, 2020

Hi @iGerchak, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants