-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removes hardcoded references to country selector component #25541
Removes hardcoded references to country selector component #25541
Conversation
Hi @krzksz. Thank you for your contribution
For more details, please, review the Magento Contributor Guide documentation. |
0625e99
to
f7e90be
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @krzksz. Thanks for collaboration. Please take a look at failed tests.
6966f65
to
ca110c5
Compare
@magento give me 2.3-develop instance |
Hi @krzksz. Thank you for your request. I'm working on Magento 2.3-develop instance for you |
Hi @krzksz, here is your Magento instance. |
ca110c5
to
e5ed9a4
Compare
@magento run all tests |
af34f26
to
cc1f7b8
Compare
cc1f7b8
to
666cca8
Compare
Hi @VladimirZaets, thank you for the review. |
✔️ QA Passed |
Hi @krzksz, thank you for your contribution! |
Description (*)
This change is aimed to fix #22416 and loosen up the coupling between shipping and country selector components in case they are moved around in the hierarchy. Applying this patch makes it possible to at least change their paths through component configuration.
Additionally, region and postcode components were refactored a bit to simplify how validation logic is written.
Fixed Issues (if relevant)
Manual testing scenarios (*)
Questions or comments
This chain is meant purely to improve developer experience when adjusting the checkout structure and shouldn't change any of the business logic.
Contribution checklist (*)