Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed Magento installation with MySQL 8. #25357

Conversation

akaplya
Copy link
Contributor

@akaplya akaplya commented Oct 29, 2019

Description (*)

Fixed Magneto installation with MySQL 8.

Fixed Issues (if relevant)

It was impossible to install Magento 2.3.3 with MySQL 8.
The cause of this issue was a forced indexation triggered by the DB patch.
The first time indexation may cause DDL scripts execution. At the same time, Magento wraps DB patches with the transaction.
As a result, Magento tries to open a new connection to perform DDL, and the original transaction does not see a table that created after the transaction started.

Reasonable workaround - do not invoke indexation from the patch. If necessary, the indexer can be invalidated.
This is a safe operation that does not require DDL execution and could be invoked from the patch.

Manual testing scenarios (*)

#25294

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@akaplya akaplya requested a review from kokoc as a code owner October 29, 2019 19:26
@m2-assistant
Copy link

m2-assistant bot commented Oct 29, 2019

Hi @akaplya. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

@magento-engcom-team
Copy link
Contributor

Hi @VladimirZaets, thank you for the review.
ENGCOM-6205 has been created to process this Pull Request
✳️ @VladimirZaets, could you please add one of the following labels to the Pull Request?

Label Description
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests
Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests
Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests

@VladimirZaets VladimirZaets added the Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests label Oct 29, 2019
@engcom-Bravo engcom-Bravo self-assigned this Oct 29, 2019
@engcom-Bravo
Copy link
Contributor

✔️ QA Passed

@engcom-Golf engcom-Golf self-assigned this Oct 31, 2019
@engcom-Golf
Copy link
Contributor

@magento run all tests

Copy link
Contributor

@novikor novikor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@ghost ghost assigned novikor Nov 6, 2019
@magento-engcom-team
Copy link
Contributor

Hi @novikor, thank you for the review.
ENGCOM-6205 has been created to process this Pull Request

@novikor novikor changed the title Fixed Magneto installation with MySQL 8. Fixed Magento installation with MySQL 8. Nov 6, 2019
@magento-engcom-team magento-engcom-team merged commit a70d66b into magento:2.3-develop Nov 7, 2019
@m2-assistant
Copy link

m2-assistant bot commented Nov 7, 2019

Hi @akaplya, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants