-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#14971 Improper Handling of Pagination SEO #25337
#14971 Improper Handling of Pagination SEO #25337
Conversation
Hi @chickenland. Thank you for your contribution
For more details, please, review the Magento Contributor Guide documentation. |
@magento run all tests |
Looks like the code test is failing on the file I've altered, but not in a function I've changed code. Shall I fix as part of this? |
Hey @chickenland, yes please fix the issues if possible. |
Hi @krzksz, thank you for the review.
|
Hi @chickenland . |
I will take care of test coverage |
Hi @krzksz all changes covered by unit test could you please review ? |
Hi @krzksz, thank you for the review. |
✔️ QA Passed |
Hi @chickenland, thank you for your contribution! |
This PR removes the p= query string parameter when navigating to the first page - to avoid duplicate content SEO issues.
Description (*)
First page pagination link include the pagination query string (for example p=1) when on a later page - which causes a duplicate content SEO issue.
Fixed Issues (if relevant) (*)
#14971: Improper Handling of Pagination SEO
Manual testing scenarios (*)
Manual testing scenarios (*)