-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add afterGetList method in CustomerRepository plugin to retrieve is_s… #25311
Add afterGetList method in CustomerRepository plugin to retrieve is_s… #25311
Conversation
Hi @enriquei4. Thank you for your contribution
For more details, please, review the Magento Contributor Guide documentation. |
Hello @enriquei4, thank you for your contribution! Due to Magento Definition of Done all code must be covered by tests. For this specific case, you should cover your fix by automated tests with the scenario which leads to an issue. Cheers! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @enriquei4,
Will you be able to update your PR and cover with tests?
…tory # Conflicts: # app/code/Magento/Newsletter/Model/Plugin/CustomerPlugin.php
Hi @ihor-sviziev, thank you for the review. |
Hi @ihor-sviziev, thank you for the review. |
Hi @enriquei4, thank you for your contribution! |
Description (*)
Its not possible to get "is_subscibed" (to newsletter) extension attribute when you retrieve the list of customers in the Customer Repository, and also in REST API.
I added a new method to getList to retrieve the subscription extension attribute.
Fixed Issues
#13252
Manual testing scenarios (*)
You wont get "extension_attributes" in the current implementation.
Contribution checklist (*)