Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #21684 - Currency sign for "Layered Navigation Price Step" is not according to default settings #24815

Conversation

Bartlomiejsz
Copy link
Contributor

@Bartlomiejsz Bartlomiejsz commented Oct 1, 2019

Description (*)

This is fix for #21684

Fixed Issues (if relevant)

  1. Currency sign for "Layered Navigation Price Step" is not according to default settings #21684: Currency sign for "Layered Navigation Price Step" is not according to default settings

Manual testing scenarios (*)

  1. Set Base Currency, Default Currency, Allow Currency to EUR
  2. Go to catalog --> Categories --> Add Sub Category
  3. Expand Display Settings
  4. Check currency symbol in Layered Navigation Price Step - it should be EUR symbol

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@Bartlomiejsz Bartlomiejsz requested a review from akaplya as a code owner October 1, 2019 21:42
@m2-assistant
Copy link

m2-assistant bot commented Oct 1, 2019

Hi @Bartlomiejsz. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

@engcom-Alfa
Copy link
Contributor

Hi @Bartlomiejsz

During testing we faced with the issue

Problem: We cannot add images to the category and delete them

Steps to reproduce:

  1. Login to Admin;
  2. Go to Catalog->Categories;
  3. Click on Default Category;
  4. In "Content" tab add some image;
  5. Click on "Save" button;

Actual result: error occurs: 'Call to undefined method Magento\Framework\Filesystem::isExist()'
after

@Bartlomiejsz Could you take a look, please?

Thanks!

@Bartlomiejsz
Copy link
Contributor Author

Hi @engcom-Alfa,
right, by accident I imported incorrect class. Fixed it now, please retest.

Thank you

@engcom-Alfa engcom-Alfa requested review from sidolov and removed request for engcom-Alfa October 4, 2019 07:41
@magento-engcom-team
Copy link
Contributor

Hi @sidolov, thank you for the review.
ENGCOM-5986 has been created to process this Pull Request

@engcom-Alfa
Copy link
Contributor

✔️ QA Passed

@ghost ghost assigned VladimirZaets Oct 25, 2019
@Bartlomiejsz Bartlomiejsz force-pushed the feature/fix_21684_currency_sign_layered_navigation_price_step branch from 3070538 to 12bfc9c Compare October 25, 2019 18:58
@Bartlomiejsz
Copy link
Contributor Author

Hi @VladimirZaets, done :)

@slavvka
Copy link
Member

slavvka commented Dec 9, 2019

Hwy @Bartlomiejsz Could you please resolve conflicts?

@Bartlomiejsz Bartlomiejsz force-pushed the feature/fix_21684_currency_sign_layered_navigation_price_step branch from 12bfc9c to d351549 Compare December 9, 2019 20:10
@Bartlomiejsz
Copy link
Contributor Author

Hi @slavvka, done

@magento-engcom-team magento-engcom-team added Partner: Fast White Cat partners-contribution Pull Request is created by Magento Partner labels Jan 6, 2020
magento-engcom-team pushed a commit that referenced this pull request Jan 8, 2020
… Step" is not according to default settings #24815
@magento-engcom-team magento-engcom-team merged commit 9c4c965 into magento:2.4-develop Jan 8, 2020
@m2-assistant
Copy link

m2-assistant bot commented Jan 8, 2020

Hi @Bartlomiejsz, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@Bartlomiejsz Bartlomiejsz deleted the feature/fix_21684_currency_sign_layered_navigation_price_step branch March 1, 2020 23:22
@sdzhepa sdzhepa mentioned this pull request May 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants