fix issue 24735 #24743

dmdanilchenko · 2019-09-27T09:33:34Z

Description (*)

Fixed Issues (if relevant)

Image in minicart is blurred on iPhone #24735: Image in minicart is blurred on iPhone

Manual testing scenarios (*)

Add product to cart
Open minicart on iPhone device

Contribution checklist (*)

Pull request has a meaningful description of its purpose
All commits are accompanied by meaningful commit messages
All new or changed code is covered with unit/integration tests (if applicable)
All automated tests passed successfully (all builds are green)

m2-assistant · 2019-09-27T09:33:36Z

Hi @dmdanilchenko. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

@magento give me test instance - deploy test instance based on PR changes
@magento give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

magento-cicd2 · 2019-09-27T09:33:37Z

All committers have signed the CLA.

VladimirZaets · 2019-09-27T09:37:40Z

Hi @dmdanilchenko , please, sign CLA, otherwise, we can't process your pull request.

nuzil · 2019-09-27T09:55:36Z

@magento give me test instance

magento-engcom-team · 2019-09-27T09:55:42Z

Hi @nuzil. Thank you for your request. I'm working on Magento instance for you

magento-engcom-team · 2019-09-27T09:56:23Z

Hi @nuzil, here is your new Magento instance.
Admin access: https://pr-24743.instances.magento-community.engineering/admin
Login: admin Password: 123123q

ihor-sviziev

Hi @dmdanilchenko,
Could you sign CLA and add your committer email to GitHub account?

dmdanilchenko · 2019-10-01T07:52:53Z

Hi @ihor-sviziev it is done.
@nuzil , thanks for support!

magento-engcom-team · 2019-10-01T08:29:39Z

Hi @ihor-sviziev, thank you for the review.
ENGCOM-5980 has been created to process this Pull Request

magento-engcom-team · 2019-10-01T08:29:41Z

@dmdanilchenko thank you for contributing. Please accept Community Contributors team invitation here to gain extended permissions for this repository.

engcom-Alfa · 2019-10-01T12:11:25Z

@magento give me 2.3-develop instance

magento-engcom-team · 2019-10-01T12:11:28Z

Hi @engcom-Alfa. Thank you for your request. I'm working on Magento 2.3-develop instance for you

magento-engcom-team · 2019-10-01T12:12:07Z

Hi @engcom-Alfa, here is your Magento instance.
Admin access: https://i-24743-2-3-develop.instances.magento-community.engineering/admin
Login: admin Password: 123123q
Instance will be terminated in up to 3 hours.

engcom-Alfa · 2019-10-01T12:19:56Z

@magento give me test instance

magento-engcom-team · 2020-02-10T11:09:57Z

Hi @engcom-Alfa. Thank you for your request. I'm working on Magento instance for you

magento-engcom-team · 2020-02-10T11:10:38Z

Hi @engcom-Alfa, here is your new Magento instance.
Admin access: https://pr-24743.instances.magento-community.engineering/admin_1923
Login: f841962b Password: 9d5174fdc343
Instance will be terminated in up to 3 hours.

engcom-Alfa · 2020-02-10T12:03:19Z

✔️ QA Passed

Before:

After:

engcom-Echo · 2020-02-13T14:24:31Z

Failed functional tests not related to the changes in this PR.

slavvka · 2020-02-18T21:53:11Z

Performance degradation approval is in progress (https://jira.corp.magento.com/browse/MC-30242)

slavvka · 2020-02-18T22:03:36Z

CompareReports\SiteSpeedCompareReports::testWebPageTestRequestsCount with data set "Customer cart" ('Customer cart', array(array(77, 74, 82, 98), array(29, 10, 4, 3, 5), array(2983946, 414712, 29559, 74204), array(5904)), array(array(77, 74, 82, 98), array(29, 10, 4, 3, 5), array(2984128, 414712, 34951, 74204), array(5862)))
Image Size in the `Customer cart` scenario is greater than on mainline. Team-fork has 18.2% degradation.

CompareReports\SiteSpeedCompareReports::testWebPageTestRequestsCount with data set "Customer checkout" ('Customer checkout', array(array(78, 76, 83, 97), array(27, 10, 4, 2, 5), array(2983946, 414712, 20473, 74204), array(5728)), array(array(78, 76, 83, 97), array(27, 10, 4, 2, 5), array(2984128, 414712, 25865, 74204), array(5731)))
Image Size in the `Customer checkout` scenario is greater than on mainline. Team-fork has 26.3% degradation.

CompareReports\SiteSpeedCompareReports::testWebPageTestRequestsCount with data set "Guest cart" ('Guest cart', array(array(77, 74, 82, 98), array(29, 10, 4, 3, 5), array(2983946, 414712, 29559, 74204), array(5942)), array(array(77, 74, 82, 98), array(29, 10, 4, 3, 5), array(2984128, 414712, 34951, 74204), array(5958)))
Image Size in the `Guest cart` scenario is greater than on mainline. Team-fork has 18.2% degradation.

CompareReports\SiteSpeedCompareReports::testWebPageTestRequestsCount with data set "Guest checkout" ('Guest checkout', array(array(78, 76, 83, 97), array(27, 10, 4, 2, 5), array(2983946, 414712, 20473, 74204), array(1928)), array(array(78, 76, 83, 97), array(27, 10, 4, 2, 5), array(2984128, 414712, 25865, 74204), array(1931)))
Image Size in the `Guest checkout` scenario is greater than on mainline. Team-fork has 26.3% degradation.

slavvka · 2020-03-04T15:54:48Z

PAT degradation is approved

slavvka

PAT degradation is approved

magento-engcom-team · 2020-03-04T15:58:44Z

Hi @slavvka, thank you for the review.
ENGCOM-5980 has been created to process this Pull Request

m2-assistant · 2020-03-12T04:28:19Z

Hi @dmdanilchenko, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

fix issue 24735

6950ead

dmdanilchenko requested a review from akaplya as a code owner September 27, 2019 09:33

magento-engcom-team added Area: Design/Frontend Area: Frontend Component: Catalog Release Line: 2.3 labels Sep 27, 2019

ihor-sviziev requested changes Sep 30, 2019

View reviewed changes

ghost assigned ihor-sviziev Sep 30, 2019

ghost added the Progress: needs update label Sep 30, 2019

dmdanilchenko requested a review from ihor-sviziev October 1, 2019 07:54

ihor-sviziev approved these changes Oct 1, 2019

View reviewed changes

ghost added Progress: ready for testing and removed Progress: needs update labels Oct 1, 2019

ihor-sviziev added the Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests label Oct 1, 2019

engcom-Alfa self-assigned this Oct 1, 2019

ghost added Progress: testing in progress and removed Progress: ready for testing labels Oct 1, 2019

ghost added Progress: extended testing and removed Progress: testing in progress labels Feb 10, 2020

engcom-Echo self-assigned this Feb 10, 2020

ghost added Progress: accept Progress: pending approval and removed Progress: extended testing Progress: accept labels Feb 13, 2020

Merge branch '2.4-develop' into fix/issue-24735

88d403c

slavvka approved these changes Mar 4, 2020

View reviewed changes

ghost added Progress: ready for testing Progress: testing in progress Progress: accept and removed Progress: pending approval Progress: ready for testing Progress: testing in progress labels Mar 4, 2020

magento-engcom-team mentioned this pull request Mar 12, 2020

Image in minicart is blurred on iPhone #24735

Closed

magento-engcom-team pushed a commit that referenced this pull request Mar 12, 2020

ENGCOM-5980: fix issue 24735 #24743

95e237a

magento-engcom-team merged commit 5ea24a1 into magento:2.4-develop Mar 12, 2020

sdzhepa mentioned this pull request May 9, 2022

tyutyu sdzhepa/magento2#5

Open

This was referenced Sep 20, 2022

#35275: Minicart thumbnail image showing wrong size in frontend which… #35470

Closed

Minicart thumbnail image showing wrong size in frontend which is half of image size in XML file #35275

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix issue 24735 #24743

fix issue 24735 #24743

dmdanilchenko commented Sep 27, 2019 •

edited

Loading

m2-assistant bot commented Sep 27, 2019

magento-cicd2 commented Sep 27, 2019 •

edited

Loading

VladimirZaets commented Sep 27, 2019

nuzil commented Sep 27, 2019

magento-engcom-team commented Sep 27, 2019

magento-engcom-team commented Sep 27, 2019

ihor-sviziev left a comment

dmdanilchenko commented Oct 1, 2019 •

edited

Loading

magento-engcom-team commented Oct 1, 2019

magento-engcom-team commented Oct 1, 2019

engcom-Alfa commented Oct 1, 2019

magento-engcom-team commented Oct 1, 2019

magento-engcom-team commented Oct 1, 2019

engcom-Alfa commented Oct 1, 2019

magento-engcom-team commented Feb 10, 2020

magento-engcom-team commented Feb 10, 2020

engcom-Alfa commented Feb 10, 2020

engcom-Echo commented Feb 13, 2020

slavvka commented Feb 18, 2020

slavvka commented Feb 18, 2020

slavvka commented Mar 4, 2020

slavvka left a comment

magento-engcom-team commented Mar 4, 2020

m2-assistant bot commented Mar 12, 2020

fix issue 24735 #24743

fix issue 24735 #24743

Conversation

dmdanilchenko commented Sep 27, 2019 • edited Loading

Description (*)

Fixed Issues (if relevant)

Manual testing scenarios (*)

Contribution checklist (*)

m2-assistant bot commented Sep 27, 2019

magento-cicd2 commented Sep 27, 2019 • edited Loading

VladimirZaets commented Sep 27, 2019

nuzil commented Sep 27, 2019

magento-engcom-team commented Sep 27, 2019

magento-engcom-team commented Sep 27, 2019

ihor-sviziev left a comment

Choose a reason for hiding this comment

dmdanilchenko commented Oct 1, 2019 • edited Loading

magento-engcom-team commented Oct 1, 2019

magento-engcom-team commented Oct 1, 2019

engcom-Alfa commented Oct 1, 2019

magento-engcom-team commented Oct 1, 2019

magento-engcom-team commented Oct 1, 2019

engcom-Alfa commented Oct 1, 2019

magento-engcom-team commented Feb 10, 2020

magento-engcom-team commented Feb 10, 2020

engcom-Alfa commented Feb 10, 2020

engcom-Echo commented Feb 13, 2020

slavvka commented Feb 18, 2020

slavvka commented Feb 18, 2020

slavvka commented Mar 4, 2020

slavvka left a comment

Choose a reason for hiding this comment

magento-engcom-team commented Mar 4, 2020

m2-assistant bot commented Mar 12, 2020

dmdanilchenko commented Sep 27, 2019 •

edited

Loading

magento-cicd2 commented Sep 27, 2019 •

edited

Loading

dmdanilchenko commented Oct 1, 2019 •

edited

Loading