Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

magento/magento2#24468: Export Coupon Code Grid redirect to DashBoard… #24608

Conversation

soniaandrianow
Copy link

… when create New Cart Price Rule

Description (*)

Fixed redirect -> not to dashboard but to edit page
Export disabled if rule is new (has no id) - export button hidden

Fixed Issues (if relevant)

  1. Export Coupon Code Grid redirect to DashBoard when create New Cart Price Rule #24468: Export Coupon Code Grid redirect to DashBoard when create New Cart Price Rule

Manual testing scenarios (*)

Go to backend
Marketing-> Cart Price Rules, Create New Cart Price Rule
In " Coupon" choose Specific Coupon
Check "Use Auto Generation"
Scroll to Manage Coupon Codes
Export shouldn't be possible

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

…ate New Cart Price Rule

Fixed redirect -> not to dashboard but to edit page
Export disabled if rule is new (has no id)
@m2-assistant
Copy link

m2-assistant bot commented Sep 15, 2019

Hi @soniaandrianow. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

@kalpmehta kalpmehta self-assigned this Sep 15, 2019
@kalpmehta
Copy link
Contributor

@soniaandrianow Please sign the CLA otherwise we cannot accept this PR.

@kalpmehta
Copy link
Contributor

Duplicate of #24471
@soniaandrianow Please feel free to re-open if you think this PR does anything extra than the #24471 PR. Thank you for your contribution.

@kalpmehta kalpmehta closed this Sep 15, 2019
@m2-assistant
Copy link

m2-assistant bot commented Sep 15, 2019

Hi @soniaandrianow, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants