Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backport] #23354 : Data saving problem error showing when leave blank qty and update it #23612

Merged
merged 1 commit into from
Jul 10, 2019
Merged

[Backport] #23354 : Data saving problem error showing when leave blank qty and update it #23612

merged 1 commit into from
Jul 10, 2019

Conversation

krishprakash
Copy link

@krishprakash krishprakash commented Jul 8, 2019 •
edited
Loading

Original Pull Request

#23360

Description (*)

Error message added if qty field left empty when qty is updated in multishipping.

Fixed Issues (if relevant)

  1. Data saving problem error showing when leave blank qty and update it #23354 : Data saving problem error showing when leave blank qty and update it

Manual testing scenarios (*)

  1. Front end -> Login into account
  2. Add more than 2 products to the cart
  3. From cart go to checkout with multiple addresses
  4. Qty leave blank and click on Update Qty & Addresses
  5. Error message "Qty field cannot be empty"

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@konarshankar07
Added data validation for the input box (+3 squashed commit)
90be3ce 
Squashed commit:

[1a39c41fdfe] Added clientside validation

[b3f97d9a78d] Added PHP Doc block for class

[fdb75fff538] error message added if qty is left empty
@m2-assistant
Copy link

m2-assistant bot commented Jul 8, 2019

Hi @krishprakash. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.2-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@krishprakash
Copy link
Author

@magento give me test instance

@magento-engcom-team
Copy link
Contributor

Hi @krishprakash. Thank you for your request. I'm working on Magento instance for you

@magento-engcom-team
Copy link
Contributor

Hi @krishprakash, here is your new Magento instance.
Admin access: https://pr-23612.instances.magento-community.engineering/admin
Login: admin Password: 123123q

@rogyar rogyar self-assigned this Jul 8, 2019
@ghost ghost unassigned sivaschenko Jul 8, 2019
@ghost
Copy link

ghost commented Jul 8, 2019

@krishprakash unfortunately, only members of the maintainers team are allowed to assign developers to the pull request

@VladimirZaets VladimirZaets self-requested a review July 9, 2019 21:08
@ghost ghost assigned VladimirZaets Jul 9, 2019
@magento-engcom-team
Copy link
Contributor

Hi @VladimirZaets, thank you for the review.
ENGCOM-5422 has been created to process this Pull Request
✳️ @VladimirZaets, could you please add one of the following labels to the Pull Request?

Label Description
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests
Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests
Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests

@engcom-Delta engcom-Delta self-assigned this Jul 10, 2019
@magento-engcom-team
Copy link
Contributor

Hi @rogyar, thank you for the review.
ENGCOM-5422 has been created to process this Pull Request
✳️ @rogyar, could you please add one of the following labels to the Pull Request?

Label Description
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests
Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests
Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests

@engcom-Delta
Copy link
Contributor

✔️ QA passed

@engcom-Foxtrot engcom-Foxtrot self-assigned this Jul 10, 2019
@magento-engcom-team magento-engcom-team mentioned this pull request Jul 10, 2019
Closed
@magento-engcom-team magento-engcom-team merged commit 90be3ce into magento:2.2-develop Jul 10, 2019
@m2-assistant
Copy link

m2-assistant bot commented Jul 10, 2019

Hi @krishprakash, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

magento-engcom-team pushed a commit that referenced this pull request Jul 10, 2019
@sivaschenko
ENGCOM-5422: [Backport] #23354 : Data saving problem error showing wh…
a5018c0 
…en leave blank qty and update it #23612
@magento-engcom-team magento-engcom-team added this to the Release: 2.2.10 milestone Jul 10, 2019
@VladimirZaets VladimirZaets added the Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests label Sep 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VladimirZaets VladimirZaets VladimirZaets approved these changes

@rogyar rogyar rogyar approved these changes

Assignees

@rogyar rogyar

@VladimirZaets VladimirZaets

@engcom-Delta engcom-Delta

@engcom-Foxtrot engcom-Foxtrot

Labels
Area: Frontend Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests Component: Multishipping Partner: Krish TechnoLabs partners-contribution Pull Request is created by Magento Partner Progress: accept Release Line: 2.2
Projects
None yet
Milestone
Release: 2.2.10
Development

Successfully merging this pull request may close these issues.
8 participants
@krishprakash @magento-engcom-team @engcom-Delta @rogyar @VladimirZaets @sivaschenko @engcom-Foxtrot @konarshankar07