Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backport] issue #22676 fixed - Compare Products counter, and My Wish List count… #23573

Merged
merged 2 commits into from
Jul 5, 2019
Merged

[Backport] issue #22676 fixed - Compare Products counter, and My Wish List count… #23573

merged 2 commits into from
Jul 5, 2019

Conversation

krishprakash
Copy link

@krishprakash krishprakash commented Jul 5, 2019 •
edited
Loading

Original Pull Request

#22742

Description (*)

I have added vertical-align:middle; to align the Compare Products counter, and My Wish List counter in the sidebar.

Fixed Issues (if relevant)

  1. Compare Products counter, and My Wish List counter vertical not aligned #22676: Compare Products counter, and My Wish List counter vertical not aligned

Manual testing scenarios (*)

  1. Added Products to Wishlist and Compare
  2. Opened Customer Account section to check the alignment in the sidebar

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@m2-assistant
Copy link

m2-assistant bot commented Jul 5, 2019

Hi @krishprakash. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.2-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@krishprakash krishprakash requested a review from sivaschenko July 5, 2019 05:17
@krishprakash
Copy link
Author

@magento give me test instance

@magento-engcom-team
Copy link
Contributor

Hi @krishprakash. Thank you for your request. I'm working on Magento instance for you

@magento-engcom-team
Copy link
Contributor

Hi @krishprakash, here is your new Magento instance.
Admin access: https://pr-23573.instances.magento-community.engineering/admin
Login: admin Password: 123123q

@krishprakash
Copy link
Author

Fixed in given instance.

@rogyar rogyar self-assigned this Jul 5, 2019
@rogyar rogyar added Port Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests labels Jul 5, 2019
@magento-engcom-team
Copy link
Contributor

Hi @rogyar, thank you for the review.
ENGCOM-5399 has been created to process this Pull Request

@engcom-Alfa engcom-Alfa self-assigned this Jul 5, 2019
@engcom-Alfa
Copy link
Contributor

✔️ QA Passed

@magento-engcom-team magento-engcom-team mentioned this pull request Jul 5, 2019
Closed
@magento-engcom-team magento-engcom-team merged commit 2a05255 into magento:2.2-develop Jul 5, 2019
@m2-assistant
Copy link

m2-assistant bot commented Jul 5, 2019

Hi @krishprakash, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

magento-engcom-team pushed a commit that referenced this pull request Jul 5, 2019
@sivaschenko
ENGCOM-5399: [Backport] issue #22676 fixed - Compare Products counter…
6cbf98b 
…, and My Wish List count… #23573
@magento-engcom-team magento-engcom-team added this to the Release: 2.2.10 milestone Jul 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rogyar rogyar rogyar approved these changes

@sivaschenko sivaschenko Awaiting requested review from sivaschenko

Assignees

@rogyar rogyar

@engcom-Alfa engcom-Alfa

Labels
Area: Design/Frontend Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests Partner: Krish TechnoLabs partners-contribution Pull Request is created by Magento Partner Progress: accept Release Line: 2.2
Projects
None yet
Milestone
Release: 2.2.10
Development

Successfully merging this pull request may close these issues.
5 participants
@krishprakash @magento-engcom-team @engcom-Alfa @rogyar @Nazar65