Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport for #23307] Allow to define listing configuration via ui component xml #23375

Merged

Conversation

Den4ik
Copy link
Contributor

@Den4ik Den4ik commented Jun 24, 2019

Original PR

#23307

Description (*)

Component paging settings allow to define pageSize and options via ui component xml. But defined variables are overridden in php and js.

Also removed unused variable from UiComponent generator

Fixed Issues (if relevant)

no related issue

Manual testing scenarios (*)

  1. Create custom listing or edit exists
  2. Add following code for paging configuration
        <paging name="listing_paging">
            <settings>
                <pageSize>30</pageSize>
                <options>
                    <option name="15" xsi:type="array">
                        <item name="label" xsi:type="string">15</item>
                        <item name="value" xsi:type="string">15</item>
                    </option>
                    <option name="30" xsi:type="array">
                        <item name="label" xsi:type="string">30</item>
                        <item name="value" xsi:type="string">30</item>
                    </option>
                    <option name="50" xsi:type="array">
                        <item name="label" xsi:type="string">50</item>
                        <item name="value" xsi:type="string">50</item>
                    </option>
                    <option name="100" xsi:type="array">
                        <item name="label" xsi:type="string">100</item>
                        <item name="value" xsi:type="string">100</item>
                    </option>
                </options>
            </settings>
        </paging>
  1. Clear cache and bookmarks

Expected result

Expected that grid will show 15, 30, 50, 100 in size selector and 30 as default value

Actual result

20, 30, 50, 100, 200 available in size selector with 20 as default value

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@m2-assistant
Copy link

m2-assistant bot commented Jun 24, 2019

Hi @Den4ik. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.2-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@magento-engcom-team
Copy link
Contributor

Hi @VladimirZaets, thank you for the review.
ENGCOM-5345 has been created to process this Pull Request
✳️ @VladimirZaets, could you please add one of the following labels to the Pull Request?

Label Description
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests
Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests
Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests

@Den4ik Den4ik added the Auto-Tests: Covered All changes in Pull Request is covered by auto-tests label Jun 25, 2019
@engcom-Alfa engcom-Alfa self-assigned this Jun 25, 2019
@engcom-Alfa
Copy link
Contributor

✔️ QA Passed

Before:

before

After:

after

@m2-assistant
Copy link

m2-assistant bot commented Jun 26, 2019

Hi @Den4ik, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

magento-engcom-team pushed a commit that referenced this pull request Jun 26, 2019
@magento-engcom-team magento-engcom-team added this to the Release: 2.2.10 milestone Jun 26, 2019
@Den4ik Den4ik deleted the back-port-pull-23307 branch June 26, 2019 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants