Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Spacing issue for Gift message section in my account #23226

Merged
merged 2 commits into from
Jul 10, 2019
Merged

Spacing issue for Gift message section in my account #23226

merged 2 commits into from
Jul 10, 2019

Conversation

amjadm61
Copy link
Member

@amjadm61 amjadm61 commented Jun 12, 2019 •
edited
Loading

Description

Spacing issue for Gift message section in my account

Fixed Issues (if relevant)

  1. Spacing issue for Gift message section in my account #22950: Spacing issue for Gift message section in my account

Manual testing scenarios (*)

  1. Admin: Add product with enable gift option
  2. Front end: Add to cart product
  3. Shopping cart: Add gift option data and place order
  4. Review at my order gift option data

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@m2-assistant
Copy link

m2-assistant bot commented Jun 12, 2019

Hi @amjadm61. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@magento-cicd2
Copy link
Contributor

magento-cicd2 commented Jun 12, 2019 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@amjadm61 amjadm61 changed the title Spacing issue for Gift message section in my account #22950 Spacing issue for Gift message section in my account Jun 12, 2019
@amjadm61
Copy link
Member Author

@magento give me test instance

@magento-engcom-team
Copy link
Contributor

Hi @amjadm61. Thank you for your request. I'm working on Magento instance for you

@magento-engcom-team
Copy link
Contributor

Hi @amjadm61, here is your new Magento instance.
Admin access: https://pr-23226.instances.magento-community.engineering/admin
Login: admin Password: 123123q

@dmytro-ch dmytro-ch self-requested a review June 12, 2019 11:36
@dmytro-ch dmytro-ch self-assigned this Jun 12, 2019
dmytro-ch
dmytro-ch requested changes Jun 12, 2019
View reviewed changes
Copy link
Contributor

@dmytro-ch dmytro-ch left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @amjadm61,
looks like you made the commits from different accounts.
We won't be able to process your pull request if you don't sign the CLA from another account as well.

Please, squash all commits into a single one in order to clean up history.

Thank you!

@amjadm61
Copy link
Member Author

@dmytro-ch i've signed the CLA from my committed account as well.

@amjadm61 amjadm61 requested a review from dmytro-ch June 12, 2019 12:05
@dmytro-ch
Copy link
Contributor

dmytro-ch commented Jun 12, 2019 •
edited
Loading

@amjadm61 , could you please, squash all commits into a single one, so the PR would not include the additional merge commits?

@amjadm61
Copy link
Member Author

@dmytro-ch Squashed all commit to single one as per your suggestion

@amjadm61
Copy link
Member Author

@amjadm61 , could you please, squash all commits into a single one, so the PR would not include the additional merge commits?

@dmytro-ch could you please check?

@dmytro-ch
Copy link
Contributor

@amacgregor, the merge commit still present in commits history.
Please make sure you pushed the changes to the remote repository.

@sidolov sidolov changed the base branch from 2.3-develop to 2.2-develop June 26, 2019 18:09
@sidolov sidolov changed the base branch from 2.2-develop to 2.3-develop June 26, 2019 18:09
@ghost ghost assigned sivaschenko Jul 5, 2019
@magento-engcom-team
Copy link
Contributor

Hi @sivaschenko, thank you for the review.
ENGCOM-5408 has been created to process this Pull Request
✳️ @sivaschenko, could you please add one of the following labels to the Pull Request?

Label Description
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests
Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests
Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests

@engcom-Alfa engcom-Alfa self-assigned this Jul 5, 2019
@engcom-Alfa
Copy link
Contributor

✔️ QA Passed

@engcom-Foxtrot engcom-Foxtrot self-assigned this Jul 8, 2019
@magento-engcom-team magento-engcom-team mentioned this pull request Jul 10, 2019
Closed
@magento-engcom-team magento-engcom-team merged commit 02ff91b into magento:2.3-develop Jul 10, 2019
@m2-assistant
Copy link

m2-assistant bot commented Jul 10, 2019

Hi @amjadm61, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

magento-engcom-team pushed a commit that referenced this pull request Jul 10, 2019
@sivaschenko
ENGCOM-5408: Spacing issue for Gift message section in my account #23226
2004ac3
@magento-engcom-team magento-engcom-team added this to the Release: 2.3.3 milestone Jul 10, 2019
@krishprakash krishprakash mentioned this pull request Jul 11, 2019
Merged
4 tasks
@sidolov sidolov added the Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests label Sep 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sivaschenko sivaschenko sivaschenko approved these changes

@dmytro-ch dmytro-ch Awaiting requested review from dmytro-ch

Assignees

@sivaschenko sivaschenko

@dmytro-ch dmytro-ch

@engcom-Alfa engcom-Alfa

@engcom-Foxtrot engcom-Foxtrot

Labels
Area: Design/Frontend Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests Cleanup Progress: accept Release Line: 2.3
Projects
None yet
Milestone
Release: 2.3.3
Development

Successfully merging this pull request may close these issues.
9 participants
@amjadm61 @magento-cicd2 @magento-engcom-team @dmytro-ch @engcom-Alfa @sivaschenko @sidolov @engcom-Foxtrot @amjadmapparel