Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backport] Fixed issue #22767: Not clear logic for loading CMS Pages with setStoreId function #23149

Merged
merged 2 commits into from
Jun 26, 2019
Merged

[Backport] Fixed issue #22767: Not clear logic for loading CMS Pages with setStoreId function #23149

merged 2 commits into from
Jun 26, 2019

Conversation

krishprakash
Copy link

@krishprakash krishprakash commented Jun 6, 2019 •
edited
Loading

Original Pull Request

#22772

Fixed: Not clear logic for loading CMS Pages with setStoreId function.

Description (*)

In this PR, i have fixed #22767 issue.

Fixed Issues (if relevant)

  1. Not clear logic for loading CMS Pages with setStoreId function  #22767
  2. ...

Manual testing scenarios (*)

  1. Tested it by programmatically.

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@m2-assistant
Copy link

m2-assistant bot commented Jun 6, 2019

Hi @krishprakash. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.2-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@ronak2ram ronak2ram self-requested a review June 6, 2019 05:22
@ronak2ram ronak2ram self-assigned this Jun 6, 2019
@magento-engcom-team
Copy link
Contributor

Hi @ronak2ram, thank you for the review.
ENGCOM-5217 has been created to process this Pull Request

@soleksii soleksii self-assigned this Jun 6, 2019
orlangur
orlangur requested changes Jun 6, 2019
View reviewed changes
Copy link
Contributor

@orlangur orlangur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@krishprakash original commit author must be preserved

@ghost ghost assigned orlangur Jun 6, 2019
mahesh-rajawat and others added 2 commits June 7, 2019 16:49
@krishprakash krishprakash force-pushed the 2.2-develop-PR-port-22772 branch from 72b91dc to 70aacf1 Compare June 7, 2019 11:25
@magento-cicd2
Copy link
Contributor

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.

Prakash Prajapati seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.

@krishprakash
Copy link
Author

@orlangur I have updated the PR as suggested by you.
Please have a look and update the PR.
Thank you.

@ghost
Copy link

ghost commented Jun 10, 2019

@krishprakash unfortunately, only members of the maintainers team are allowed to remove progress related labels to the pull request

@krishprakash
Copy link
Author

krishprakash commented Jun 13, 2019 •
edited
Loading

@orlangur
Is there anything remaining from my end ?
If any please let me know.
Otherwise please update the status of PR.
Thanks.

@ghost
Copy link

ghost commented Jun 19, 2019

@magento-cicd2 unfortunately, only members of the maintainers team are allowed to unassign developers from the pull request

@ghost ghost removed the Progress: needs update label Jun 22, 2019
@magento-engcom-team
Copy link
Contributor

Hi @orlangur, thank you for the review.
ENGCOM-5217 has been created to process this Pull Request
✳️ @orlangur, could you please add one of the following labels to the Pull Request?

Label Description
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests
Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests
Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests

@orlangur orlangur added the Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests label Jun 22, 2019
@engcom-Alfa engcom-Alfa self-assigned this Jun 24, 2019
@engcom-Alfa
Copy link
Contributor

✔️ QA Passed

@engcom-Golf engcom-Golf self-assigned this Jun 24, 2019
@sidolov sidolov added the Port label Jun 24, 2019
@magento-engcom-team magento-engcom-team mentioned this pull request Jun 26, 2019
Closed
@magento-engcom-team magento-engcom-team merged commit 70aacf1 into magento:2.2-develop Jun 26, 2019
@m2-assistant
Copy link

m2-assistant bot commented Jun 26, 2019

Hi @krishprakash, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

magento-engcom-team pushed a commit that referenced this pull request Jun 26, 2019
@sidolov
ENGCOM-5217: [Backport] Fixed issue #22767: Not clear logic for loadi…
b52d045 
…ng CMS Pages with setStoreId function #23149
@magento-engcom-team magento-engcom-team added this to the Release: 2.2.10 milestone Jun 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ronak2ram ronak2ram ronak2ram approved these changes

@orlangur orlangur orlangur approved these changes

Assignees

@orlangur orlangur

@ronak2ram ronak2ram

@engcom-Alfa engcom-Alfa

@engcom-Golf engcom-Golf

Labels
Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests Component: Cms Partner: Krish TechnoLabs partners-contribution Pull Request is created by Magento Partner Progress: accept Release Line: 2.2
Projects
None yet
Milestone
Release: 2.2.10
Development

Successfully merging this pull request may close these issues.