Fix random fails during parallel SCD execution

[ihor-sviziev]

Description (*)

No need to use locks when running in CLI mode, for instance during running php bin/magneto setup:static-content:deploy

Fixed Issues (if relevant)

1. Static content deploy - Randomly css files not generated #22880: Static content deploy - Randomly css files not generated

Manual testing scenarios (*)

1. ...
2. ...

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• All automated tests passed successfully (all builds are green)

[m2-assistant]

Hi @ihor-sviziev. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento-engcom-team give me test instance - deploy test instance based on PR changes
• @magento-engcom-team give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

[VladimirZaets]

Hi @ihor-sviziev. Thanks for collaboration. Please fix static and unit tests.

[ihor-sviziev]

Hi @VladimirZaets,
Static tests complains about lines that I didn't changed. I think it could be fixed during processing PR.

About unit tests - not sure how I could fix it because unit tests are always running from CLI. Could you point me or maybe fix it by internal team?

[ihor-sviziev]

Hi @VladimirZaets,
I fixed static tests, but not sure how to fix unit tests for this case.

Also I analyzed all places that I we have currently in magento where used PHP_SAPI constant or php_sapi_name function - all of them just not covered with unit tests, probably because of mentioned issue.

So I see there two options:

1. Remove existing unit tests
2. Introduce some class in Magento Framework that will have isCli method and use it. As for me - that's wrong way.

I don't mind if you'll fix unit tests internally using any different approach

[ihor-sviziev]

Hi @VladimirZaets @sidolov,
Could you point me what to do with this case?

[VladimirZaets]

Hi @ihor-sviziev. Thanks for collaboration. I discussed this case with our architectors and we think that we can remove this unit test

[ihor-sviziev]

Hi @ihor-sviziev. Thanks for collaboration. I discussed this case with our architectors and we think that we can remove this unit test

Done

[magento-engcom-team]

Hi @VladimirZaets, thank you for the review.
ENGCOM-5582 has been created to process this Pull Request
✳️ @VladimirZaets, could you please add one of the following labels to the Pull Request?

Label	Description
Auto-Tests: Covered	All changes in Pull Request is covered by auto-tests
Auto-Tests: Not Covered	Changes in Pull Request requires coverage by auto-tests
Auto-Tests: Not Required	Changes in Pull Request does not require coverage by auto-tests

[engcom-Delta]

✔️ QA passed

[m2-assistant]

Hi @ihor-sviziev, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.