Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolved issue #22845

Closed
wants to merge 1 commit into from
Closed

Resolved issue #22845

wants to merge 1 commit into from

Conversation

mallikaverma
Copy link

Fixed issue #22304 [Grouped product] Can´t add simple products to cart if one other is out of stock.

Description (*)

Fixed issue #22304 [Grouped product] Can´t add simple products to cart if one other is out of stock.

Fixed Issues (if relevant)

Fixed issue #22304 [Grouped product] Can´t add simple products to cart if one other is out of stock.

  1. [Grouped product] Can´t add simple products to cart if one other is out of stock #22304 : [Grouped product] Can´t add simple products to cart if one other is out of stock.

Manual testing scenarios (*)

1.enable the option allow to show products without stock
2.grouped product with more sub items
3.at least one sub items have to be without stock (quantity=0)
4.navigate to the PDS of the grouped product
5.add at least on item of any available sub item
6.if you add the item to the cart the message "Please specify the quantity of product(s)." apears

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@m2-assistant
Copy link

m2-assistant bot commented May 12, 2019

Hi @mallikaverma. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@arnoudhgz
Copy link
Contributor

@mallikaverma I tried this solution as a patch in my project, but now I completely see no child products anymore on my product page.

@dmytro-ch dmytro-ch self-requested a review May 27, 2019 13:47
@dmytro-ch dmytro-ch self-assigned this May 27, 2019
@dmytro-ch dmytro-ch added Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release and removed Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release labels May 27, 2019
Copy link
Contributor

@dmytro-ch dmytro-ch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @mallikaverma,
thank you for your contribution!

Unfortunately, the current solution is rather a workaround and it does not solve the real issue.
We should not ignore the option that allows showing products without stock.

@sidolov
Copy link
Contributor

sidolov commented Jun 13, 2019

@mallikaverma , I am closing this PR now due to inactivity.
Please reopen and update if you wish to continue.
Thank you for the collaboration!

@sidolov sidolov closed this Jun 13, 2019
@m2-assistant
Copy link

m2-assistant bot commented Jun 13, 2019

Hi @mallikaverma, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants